self-heal: re-verify BOTH halves before declaring the fix resolved - #2
Open
MattJackson wants to merge 1 commit into
Open
self-heal: re-verify BOTH halves before declaring the fix resolved#2MattJackson wants to merge 1 commit into
MattJackson wants to merge 1 commit into
Conversation
The auto-fix retry re-ran only the valid-config half. A fix that repaired the valid case while breaking the invalid case still set resolved=true, committed the mangled fixture, and FORCE-MOVED the v1 tag that every consumer of this action rides — silently, on a schedule, with no human in the loop. That is the most consequential green in this repo: it publishes. The retry now runs both halves and only reports resolved when both pass. The _scratch/ fixtures deleted while testing this have been restored; they are tracked on purpose (6848b2b) and the workflow needs them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No check goes red as a result of this change — this one narrows a green that was being issued too easily. Part of a fleet-wide sweep for checks that report GREEN without having checked anything (21 found, 17 proven).
Why this is the most consequential green in the repo: it publishes
The auto-fix retry re-ran only the valid-config half. A "fix" that repaired the valid case while breaking the invalid case still set
resolved=true, committed the mangled fixture, and force-moved thev1tag that every consumer of this action rides — silently, on a schedule, with no human in the loop.Most false greens let a bad thing through. This one actively ships it to every consumer.
The retry now runs both halves and reports
resolvedonly when both pass. Proven: constructed a fix passing the valid half and failing the invalid half, watched the old workflow declare success and move the tag; the fixed workflow refuses.Housekeeping
The
_scratch/fixtures deleted during testing have been restored. They are tracked deliberately (6848b2b) and the workflow needs them — deleting them was test collateral, not part of the fix.