ci: make public-hygiene-lint green - #6
Merged
Conversation
added 2 commits
August 8, 2026 16:00
The public-hygiene gate flags text in customer-readable files that describes how the software was BUILT rather than what it DOES. Every hit in this repo is rewritten to state the behaviour or the invariant; no allow markers are added, so the gate keeps its teeth.
full_stack_e2e asserted that one real request produces exactly one webhook
call. Against busbar 1.5.3 it produces four. That is a documented breaking
change, not a regression:
busbarAI CHANGELOG.md, "[1.5.3] Breaking changes":
"A hand-written hook with no stage list now fires at all four stages
rather than once per request; set `phase: [request]` for the old
behaviour."
The test registered its tap over the admin API with no stage scoping, so it
was getting the new all-stages fan-out: the stage-less request envelope plus
`stage.at` of candidate, routing and response. The assertion was encoding the
pre-1.5.3 default, not a property of this plugin.
This repo's `.busbar-ref` already pins 1.5.3, so the suite was asserting a
contract the core it releases against had already retired.
stage_fanout_e2e is a new file rather than more cases in full_stack_e2e: the
fan-out is its own contract and deserves to be readable on its own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
public-hygiene-lint was RED on
mainin this repo. Every hit is fixed by rewriting the text tostate the BEHAVIOUR rather than our internal process. No allow markers were added anywhere in
this change: a blanket allow would turn the gate into decoration.
Hits found on
main, and the decision for each.github/scripts/next-version.sh+.github/workflows/release-selftest.yml[internal-issue-id]cited an internal guard id. REWRITTEN: the sentences already state what the self-test does, so
the id is simply dropped.
tests/e2e.rs,tests/full_stack_e2e.rs[mutation-testing] named an internal QA harness as theexample of a build invocation that does not uplift the cdylib. REWRITTEN to describe the build
shape itself (a plain
cargo testwith no prior--all-targets/--libbuild), which is thefact the helper actually depends on.
Red before green
Same invocation CI uses. Output is ASCII-folded for this description; the runs are verbatim
otherwise.
Before (on
main)After (this branch)