chore(repo): align sfu events naming with other SDKs#1279
Conversation
|
Warning Review limit reached
Next review available in: 57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe change centralizes tracing identifiers in ChangesTrace tag migration and SFU event serialization
Estimated code review effort: 2 (Simple) | ~15 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1279 +/- ##
==========================================
- Coverage 11.17% 11.07% -0.11%
==========================================
Files 686 686
Lines 50320 50337 +17
==========================================
- Hits 5625 5576 -49
- Misses 44695 44761 +66 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/stream_video/lib/src/call/stats/trace_tag.dart (1)
76-91: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winInconsistent failure suffix:
.failurevs.errorThe SFU RPCs and
createOffer/createAnsweruse.failurefor their error tags, whilesetRemoteDescription,setLocalDescription, andaddIceCandidateuse.error. Since this PR's stated goal is aligning naming conventions, consider standardizing on one suffix.♻️ Suggested alignment to `.failure`
- static const String setRemoteDescriptionError = 'setRemoteDescription.error'; + static const String setRemoteDescriptionFailure = 'setRemoteDescription.failure';- static const String setLocalDescriptionError = 'setLocalDescription.error'; + static const String setLocalDescriptionFailure = 'setLocalDescription.failure';- static const String addIceCandidateError = 'addIceCandidate.error'; + static const String addIceCandidateFailure = 'addIceCandidate.failure';🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/stream_video/lib/src/call/stats/trace_tag.dart` around lines 76 - 91, Standardize the error tag suffixes in the trace-tag constants by renaming setRemoteDescriptionError, setLocalDescriptionError, and addIceCandidateError to use `.failure`, matching the existing SFU RPC and createOffer/createAnswer conventions; update all references to these symbols accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/stream_video/lib/src/call/stats/trace_tag.dart`:
- Around line 76-91: Standardize the error tag suffixes in the trace-tag
constants by renaming setRemoteDescriptionError, setLocalDescriptionError, and
addIceCandidateError to use `.failure`, matching the existing SFU RPC and
createOffer/createAnswer conventions; update all references to these symbols
accordingly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a7c2c0e4-61cb-425f-8019-003af90f2e7a
📒 Files selected for processing (10)
packages/stream_video/lib/src/call/call.dartpackages/stream_video/lib/src/call/session/call_session.dartpackages/stream_video/lib/src/call/stats/sfu_stats_reporter.dartpackages/stream_video/lib/src/call/stats/trace_tag.dartpackages/stream_video/lib/src/sfu/sfu_client.dartpackages/stream_video/lib/src/sfu/sfu_extensions.dartpackages/stream_video/lib/src/webrtc/media/media_constraints.dartpackages/stream_video/lib/src/webrtc/peer_connection_factory.dartpackages/stream_video/lib/src/webrtc/rtc_media_device/rtc_media_device_notifier.dartpackages/stream_video/lib/src/webrtc/traced_peer_connection.dart
# Conflicts: # packages/stream_video/lib/src/call/session/call_session.dart
Summary by CodeRabbit
New Features
Improvements