data(smartphone): import PhoneDB raw variants (batch 2-3) + normalize names#28
Merged
Conversation
Member
Author
Validation review — PASS ✅Commands run (local):
Data changes vs
Example record — { "slug": "samsung-sm-s9480-galaxy-s26-ultra-5g-dual-sim-td-lte-cn-hk-tw-512gb-samsung-miracle-3",
"name": "Samsung SM-S9480 Galaxy S26 Ultra 5G Dual SIM TD-LTE CN HK TW 512GB (Samsung Miracle 3)",
"brand": "samsung", "soc": "qualcomm-snapdragon-8-elite-gen-5-sm8850-1-ad-for-galaxy",
"release_date": "2026-03-11", "ram_gb": 12, "battery_mah": 5000, "os": "Android",
"verified": false, "source_urls": ["https://phonedb.net/index.php?m=device&id=25688"] }Heuristic warnings: the double-space names flagged on #27 are fixed (7,168 normalized). Remaining integrity-gate ratio outliers are pre-existing GPU/CPU benchmark notes, unrelated to this PR. Site build: N/A (no |
Member
Author
Dataset stats (post-merge projection)
Warning Verified coverage is far below 50% (smartphone 0.7%, soc 3.3%) — expected for bulk raw seed imports. Verification is deferred to TechEngine / manual audit per the import workflow. |
Member
TechEngine change review: PASS
Changed data
Changed record examplessoc added
smartphone added
smartphone modified
Heuristic review
|
Member
TechEngine validation stats: PASS
Data summary
Warning Tracked verified coverage is below 50% for brand 0.0% (0/60), gpu 0.0% (0/2030), smartphone 0.7% (184/24655), soc 3.3% (58/1773), all 3.7% (1218/32495), cpu 24.5% (976/3977). Validation notes
Key output:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continues the PhoneDB variant-level import (batch 1 landed in #27). Adds ~5,450 new variant-level smartphones + 86 SoC seeds, normalizes 7,168 device names (fixes the #27 double-space heuristic warnings), and refreshes the public dump. All raw seed (
verified: false) with per-recordsource_urlsto phonedb.net.Changes vs
mainverified: false).site/public/v1dump refreshed as the final commit → now 24,655 smartphones / 1,773 SoC (was stale at 19,205 / 1,560).Refs #1in each commit body.Validation (local)
python -m app.validate→ ✅ passedpython TechEngine/integrity_check.py data --strict→ ✅ no hard anomaliesdata/dir could not contaminate it).Closes #1