Skip to content

data(brand): real descriptions for recognizable brands#45

Merged
Seungpyo1007 merged 2 commits into
mainfrom
data/brand-descriptions
Jun 21, 2026
Merged

data(brand): real descriptions for recognizable brands#45
Seungpyo1007 merged 2 commits into
mainfrom
data/brand-descriptions

Conversation

@Seungpyo1007

Copy link
Copy Markdown
Member

Summary

Replace the generic placeholder brand descriptions ("Phone brand observed in the GSMArena mobile devices dataset…") with real, factual EN + KO descriptions for 53 recognizable brands (Sony Ericsson, Palm, Vodafone, Orange, O2, Casio, Dell, HP, Amazon, T-Mobile, Bosch, Haier, Sagem, Sonim, Telit, Thuraya, Benefon, Qtek, E-TEN, MiTAC, Karbonn, Intex, verykool, Yezz, …).

Changes

  • 53 data/brand/**/*.json: real description_en + description_ko (replacing the placeholder + filling the missing Korean field).
  • 53 matching site/public/v1/brands/<slug>/index.json dump details refreshed (descriptions are verbatim passthrough, so the dump matches a full regenerate).
  • 7 genuinely-obscure brands (Chea, XCute, MWg, Parla, NIU, WND, …) intentionally keep their provenance placeholder — no fabricated facts.
  • Descriptions are conservative (region/segment) for unaudited brands (verified: false); audit can refine later.

Verification

  • python -m app.validate PASS
  • python TechEngine/integrity_check.py data --strict PASS
  • git diff --check origin/main...HEAD PASS
  • Local site build skipped (isolated worktree has no node_modules); change is build-safe description text and the TechEngine homepage validation builds the site.

Closes #1

Replace generic placeholder descriptions with factual EN/KO descriptions for 53 well-known brands (Sony Ericsson, Palm, Vodafone, Casio, Dell, HP, etc.). Obscure brands keep their provenance placeholder to avoid fabrication.

Refs #1
@Seungpyo1007 Seungpyo1007 added the data Dataset changes label Jun 21, 2026
@Seungpyo1007 Seungpyo1007 self-assigned this Jun 21, 2026
@github-actions github-actions Bot added the enhancement New feature or request label Jun 21, 2026
@Seungpyo1007 Seungpyo1007 moved this from Todo to In Progress in TechAPI-Project Jun 21, 2026
@Seungpyo1007 Seungpyo1007 merged commit 9449a70 into main Jun 21, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in TechAPI-Project Jun 21, 2026
@TechEngineBot

Copy link
Copy Markdown
Member

TechEngine change review: PASS

Check Result
python -m app.validate PASS
python integrity_check.py TechAPI/data --strict PASS

Changed data

Category Added Modified Deleted Added verified Added unverified Added Kaggle-sourced
brand 0 0 0 0 0 0
soc 0 0 0 0 0 0
smartphone 0 0 0 0 0 0
tablet 0 0 0 0 0 0
watch 0 0 0 0 0 0
pda 0 0 0 0 0 0
gpu 0 0 0 0 0 0
cpu 0 0 0 0 0 0

Changed record examples

  • No data file changes detected.

Heuristic review

  • Heuristic warnings: none found.

@TechEngineBot

Copy link
Copy Markdown
Member

TechEngine validation stats: PASS

Data summary

Category Total Verified Unverified Missing verified Tracked Verified % of tracked
brand 189 0 189 0 189 0.0%
soc 2104 58 2046 0 2104 2.8%
smartphone 90118 184 89934 0 90118 0.2%
tablet 3048 0 3048 0 3048 0.0%
watch 378 0 378 0 378 0.0%
pda 110 0 110 0 110 0.0%
gpu 2030 0 2030 0 2030 0.0%
cpu 3977 976 3001 0 3977 24.5%
all 101954 1218 100736 0 101954 1.2%

Warning

Tracked verified coverage is below 50% for brand 0.0% (0/189), tablet 0.0% (0/3048), watch 0.0% (0/378), pda 0.0% (0/110), gpu 0.0% (0/2030), smartphone 0.2% (184/90118), all 1.2% (1218/101954), soc 2.8% (58/2104), and 1 more.
Tracked coverage excludes records missing the verified field; see the Missing verified column for those records.
This does not fail validation. Keep imported records verified: false until manual audit, but treat this as follow-up verification work before relying on the affected categories as curated data.

Validation notes

  • Full advisory outlier listings are suppressed on successful runs because they are dataset-wide and mostly stable between PRs.
  • Failure runs still include a detailed log excerpt for debugging.

Key output:

## app.validate
## integrity_check.py --strict
loaded CPU=3977 GPU=2030
✅ integrity gate: no hard anomalies.
Integrity section Flagged lines
structural 0
CPU name/tier consistency (desktop mainstream only) 0
CPU single>multi (cinebench/geekbench — should be multi>=single) 0
CPU era-vs-score outliers 8
CPU cross-source ratio outliers (possible wrong-variant) 152
GPU cross-source ratio outliers + sanity 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data Dataset changes enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Massive dataset rebuild: CPU + brand + GPU + smartphone + SoC (1989-2026)

2 participants