data(brand): real descriptions for recognizable brands#45
Merged
Conversation
Replace generic placeholder descriptions with factual EN/KO descriptions for 53 well-known brands (Sony Ericsson, Palm, Vodafone, Casio, Dell, HP, etc.). Obscure brands keep their provenance placeholder to avoid fabrication. Refs #1
Member
TechEngine change review: PASS
Changed data
Changed record examples
Heuristic review
|
Member
TechEngine validation stats: PASS
Data summary
Warning Tracked verified coverage is below 50% for brand 0.0% (0/189), tablet 0.0% (0/3048), watch 0.0% (0/378), pda 0.0% (0/110), gpu 0.0% (0/2030), smartphone 0.2% (184/90118), all 1.2% (1218/101954), soc 2.8% (58/2104), and 1 more. Validation notes
Key output:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the generic placeholder brand descriptions ("Phone brand observed in the GSMArena mobile devices dataset…") with real, factual EN + KO descriptions for 53 recognizable brands (Sony Ericsson, Palm, Vodafone, Orange, O2, Casio, Dell, HP, Amazon, T-Mobile, Bosch, Haier, Sagem, Sonim, Telit, Thuraya, Benefon, Qtek, E-TEN, MiTAC, Karbonn, Intex, verykool, Yezz, …).
Changes
data/brand/**/*.json: realdescription_en+description_ko(replacing the placeholder + filling the missing Korean field).site/public/v1/brands/<slug>/index.jsondump details refreshed (descriptions are verbatim passthrough, so the dump matches a full regenerate).verified: false); audit can refine later.Verification
python -m app.validatePASSpython TechEngine/integrity_check.py data --strictPASSgit diff --check origin/main...HEADPASSnode_modules); change is build-safe description text and the TechEngine homepage validation builds the site.Closes #1