Skip to content

data(watch): drop invalid sub-1GB storage_options_gb from Huawei 2018 watches#53

Merged
Seungpyo1007 merged 2 commits into
mainfrom
data/fix-huawei-watch-storage
Jun 22, 2026
Merged

data(watch): drop invalid sub-1GB storage_options_gb from Huawei 2018 watches#53
Seungpyo1007 merged 2 commits into
mainfrom
data/fix-huawei-watch-storage

Conversation

@Seungpyo1007

@Seungpyo1007 Seungpyo1007 commented Jun 22, 2026

Copy link
Copy Markdown
Member

What

Huawei Watch GT and Huawei Watch Magic (2018) carried storage_options_gb: [0.125] (128 MB stored as fractional GB). That is not a valid integer-GB value:

  • app.validate._check_storage_options_gb requires int >= 1.
  • TechEngine's MobileDeviceRead schema rejects the fractional float, which breaks the static dump (test_dump fails: Input should be a valid integer, got 0.125).

Because TechEngine's test.yml checks out TechAPI main live and seeds from it, this one bad value fails the test suite on every TechEngine PR.

Fix

Remove the optional storage_options_gb field from both records (surgical text removal — no reserialization, all other fields byte-identical). 128 MB cannot be represented as integer GB and the field is optional, so dropping it is the clean fix.

Effect

Unblocks TechEngine CI (and the weekly-refresh dump). The public site/public/v1 dump is regenerated by the refresh pipeline.

Closes #1

… watches

Huawei Watch GT/Magic carried storage_options_gb: [0.125] (128 MB), which is
not a valid integer-GB value: app.validate requires int >= 1 and TechEngine's
MobileDeviceRead rejects the fractional float, breaking the static dump. Remove
the field (the optional storage list) so the records validate and dump cleanly.

Refs #1
… watches

Huawei Watch GT/Magic carried storage_options_gb: [0.125] (128 MB), which is
not a valid integer-GB value: app.validate requires int >= 1 and TechEngine's
MobileDeviceRead rejects the fractional float, breaking the static dump. Remove
the field (the optional storage list) so the records validate and dump cleanly.

Refs #1
@github-actions github-actions Bot added data Dataset changes enhancement New feature or request labels Jun 22, 2026
@Seungpyo1007 Seungpyo1007 moved this from Todo to In Progress in TechAPI-Project Jun 22, 2026
@Seungpyo1007 Seungpyo1007 merged commit 6ea442a into main Jun 22, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in TechAPI-Project Jun 22, 2026
@Seungpyo1007 Seungpyo1007 deleted the data/fix-huawei-watch-storage branch June 22, 2026 04:43
@TechEngineBot

Copy link
Copy Markdown
Member

TechEngine change review: PASS

Check Result
python -m app.validate PASS
python integrity_check.py TechAPI/data --strict PASS

Changed data

Category Added Modified Deleted Added verified Added unverified Added Kaggle-sourced
brand 0 0 0 0 0 0
soc 0 0 0 0 0 0
smartphone 0 0 0 0 0 0
tablet 0 0 0 0 0 0
watch 0 0 0 0 0 0
pda 0 0 0 0 0 0
gpu 0 0 0 0 0 0
cpu 0 0 0 0 0 0

Changed record examples

  • No data file changes detected.

Heuristic review

  • Heuristic warnings: none found.

@TechEngineBot

Copy link
Copy Markdown
Member

TechEngine validation stats: PASS

Data summary

Category Total Verified Unverified Missing verified Tracked Verified % of tracked
brand 189 0 189 0 189 0.0%
soc 2104 58 2046 0 2104 2.8%
smartphone 90118 184 89934 0 90118 0.2%
tablet 3048 0 3048 0 3048 0.0%
watch 378 0 378 0 378 0.0%
pda 110 0 110 0 110 0.0%
gpu 2030 0 2030 0 2030 0.0%
cpu 3977 976 3001 0 3977 24.5%
all 101954 1218 100736 0 101954 1.2%

Warning

Tracked verified coverage is below 50% for brand 0.0% (0/189), tablet 0.0% (0/3048), watch 0.0% (0/378), pda 0.0% (0/110), gpu 0.0% (0/2030), smartphone 0.2% (184/90118), all 1.2% (1218/101954), soc 2.8% (58/2104), and 1 more.
Tracked coverage excludes records missing the verified field; see the Missing verified column for those records.
This does not fail validation. Keep imported records verified: false until manual audit, but treat this as follow-up verification work before relying on the affected categories as curated data.

Validation notes

  • Full advisory outlier listings are suppressed on successful runs because they are dataset-wide and mostly stable between PRs.
  • Failure runs still include a detailed log excerpt for debugging.

Key output:

## app.validate
## integrity_check.py --strict
loaded CPU=3977 GPU=2030
✅ integrity gate: no hard anomalies.
Integrity section Flagged lines
structural 0
CPU name/tier consistency (desktop mainstream only) 0
CPU single>multi (cinebench/geekbench — should be multi>=single) 0
CPU era-vs-score outliers 8
CPU cross-source ratio outliers (possible wrong-variant) 152
GPU cross-source ratio outliers + sanity 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data Dataset changes enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Massive dataset rebuild: CPU + brand + GPU + smartphone + SoC (1989-2026)

2 participants