Skip to content

fix(verify): shallow-safe changed-record detection (unblocks Tiers 1-3)#62

Merged
Seungpyo1007 merged 1 commit into
mainfrom
fix/changed-diff-shallow
Jun 22, 2026
Merged

fix(verify): shallow-safe changed-record detection (unblocks Tiers 1-3)#62
Seungpyo1007 merged 1 commit into
mainfrom
fix/changed-diff-shallow

Conversation

@Seungpyo1007

Copy link
Copy Markdown
Member

CI fetches main --depth=1; the three-dot origin/main...HEAD diff needs a merge-base that a shallow main lacks, so --changed/pr always saw 0 changed records and skipped the network tiers. Switch to a direct git diff origin/main HEAD (only needs both tips). Refs #1

CI fetches main with --depth=1, so the three-dot origin/main...HEAD diff has no
merge-base and silently returned nothing — every '--changed'/'pr' run saw 0
changed records and skipped Tiers 1-3. Use a direct two-tree diff (origin/main
HEAD) which only needs both tips. Refs #1
@github-actions github-actions Bot added app Validator or application code changes bug Something isn't working enhancement New feature or request labels Jun 22, 2026
@Seungpyo1007

Copy link
Copy Markdown
Member Author

🔎 Data verification — Tier 0 (offline existence/trust)

Scored by app.verify; posted by TechEngineBot. Informational only — the structural gate (app.validate) is separate and authoritative for merge.

Changed records in this PR

No records scored.

Full-dataset baseline

101954 record(s) scored.

Category Total 🟢 Green 🟡 Yellow 🔴 Red Green %
brand 189 10 179 0 5.3%
soc 2104 123 680 1301 5.8%
smartphone 90118 8453 80547 1118 9.4%
tablet 3048 174 2846 28 5.7%
watch 378 11 357 10 2.9%
pda 110 27 77 6 24.5%
gpu 2030 245 1785 0 12.1%
cpu 3977 976 3001 0 24.5%
All 101954 10019 89472 2463 9.8%

green = authoritative source + complete + consistent · yellow = plausible, needs confirmation · red = sparse/weak source or a hard contradiction. Promotion to verified runs in the scheduled verify-network workflow.

@Seungpyo1007 Seungpyo1007 merged commit 85e6d51 into main Jun 22, 2026
3 checks passed
@Seungpyo1007 Seungpyo1007 deleted the fix/changed-diff-shallow branch June 22, 2026 06:28
@github-project-automation github-project-automation Bot moved this from Todo to Done in TechAPI-Project Jun 22, 2026
@TechEngineBot

Copy link
Copy Markdown
Member

TechEngine change review: PASS

Check Result
python -m app.validate PASS
python integrity_check.py TechAPI/data --strict PASS

Changed data

Category Added Modified Deleted Added verified Added unverified Added Kaggle-sourced
brand 0 0 0 0 0 0
soc 0 0 0 0 0 0
smartphone 0 0 0 0 0 0
tablet 0 0 0 0 0 0
watch 0 0 0 0 0 0
pda 0 0 0 0 0 0
gpu 0 0 0 0 0 0
cpu 0 0 0 0 0 0

Changed record examples

  • No data file changes detected.

Heuristic review

  • Heuristic warnings: none found.

@TechEngineBot

Copy link
Copy Markdown
Member

TechEngine validation stats: PASS

Data summary

Category Total Verified Unverified Missing verified Tracked Verified % of tracked
brand 189 0 189 0 189 0.0%
soc 2104 58 2046 0 2104 2.8%
smartphone 90118 184 89934 0 90118 0.2%
tablet 3048 0 3048 0 3048 0.0%
watch 378 0 378 0 378 0.0%
pda 110 0 110 0 110 0.0%
gpu 2030 0 2030 0 2030 0.0%
cpu 3977 976 3001 0 3977 24.5%
all 101954 1218 100736 0 101954 1.2%

Warning

Tracked verified coverage is below 50% for brand 0.0% (0/189), tablet 0.0% (0/3048), watch 0.0% (0/378), pda 0.0% (0/110), gpu 0.0% (0/2030), smartphone 0.2% (184/90118), all 1.2% (1218/101954), soc 2.8% (58/2104), and 1 more.
Tracked coverage excludes records missing the verified field; see the Missing verified column for those records.
This does not fail validation. Keep imported records verified: false until manual audit, but treat this as follow-up verification work before relying on the affected categories as curated data.

Validation notes

  • Full advisory outlier listings are suppressed on successful runs because they are dataset-wide and mostly stable between PRs.
  • Failure runs still include a detailed log excerpt for debugging.

Key output:

## app.validate
## integrity_check.py --strict
loaded CPU=3977 GPU=2030
✅ integrity gate: no hard anomalies.
Integrity section Flagged lines
structural 0
CPU name/tier consistency (desktop mainstream only) 0
CPU single>multi (cinebench/geekbench — should be multi>=single) 0
CPU era-vs-score outliers 8
CPU cross-source ratio outliers (possible wrong-variant) 152
GPU cross-source ratio outliers + sanity 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app Validator or application code changes bug Something isn't working enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants