fix(verify): stop the verify-status sync loop (idempotent status.json)#36
Merged
Conversation
cmd_status rewrote generated_at every run, so verify-status always committed a new status.json, which re-dispatched techapi-updated and re-ran itself (~every 3 min). Preserve the prior timestamp when the verification numbers are unchanged so the file stays byte-identical and nothing is committed. Refs #1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
verify-statusandbump-techapiwere firing every ~3 minutes in an endless loop. Root cause:app.verify statusstamps a freshgenerated_aton every run, so the committedstatus.jsonalways differed → verify-status committed → that push re-fired thetechapi-updateddispatch → verify-status ran again → forever.Fix: when the verification numbers are unchanged, preserve the previous
generated_atso the file is byte-identical and nothing gets committed. (A companion TechAPI PR also addsdata/_verify/**to notify-engine's paths-ignore as defense-in-depth.)Refs #1