pretty much the same just some optimization#2
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors repeated theme styling primitives (border, radius, standard margins) into a shared panel() SCSS mixin and applies it across multiple theme modules, alongside a couple small CSS optimizations/refactors.
Changes:
- Added
@mixin panel(...)in the backend and re-exported it viasrc/backend/_index.scss. - Replaced repeated
border/border-radius/margin-*declarations in many theme partials with@include panel(...). - Switched hover-slide animations from
margin-lefttotransform: translateX(...)and refactored a few long selectors for readability.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/backend/_mixins.scss | Introduces panel() mixin to centralize common panel styling (border/radius/margins). |
| src/backend/_index.scss | Re-exports the new mixin module via @forward 'mixins'. |
| src/theme/_voicecall.scss | Uses panel() to reduce duplicated panel styling in voice call UI. |
| src/theme/_settings.scss | Uses panel() for settings content/sidebar panel styling. |
| src/theme/_serverboost.scss | Uses panel() for server boost container styling. |
| src/theme/_server.scss | Replaces repeated border/radius/margin patterns with panel() across server views. |
| src/theme/_search.scss | Uses panel() for search results wrapper panel styling. |
| src/theme/_quest.scss | Uses panel() for quest claimed container styling. |
| src/theme/_profilev2.scss | Uses panel() for profile v2 panel borders/radius. |
| src/theme/_home.scss | Uses panel() for DM/friends/shop panels and margins. |
| src/theme/_global.scss | Uses panel() for several global popout/panel border/radius rules. |
| src/theme/_forum.scss | Uses panel() for forum container/header panels. |
| src/theme/_embed.scss | Uses panel() for embed-related panel borders/radius. |
| src/theme/_chat.scss | Uses panel() for chat UI panels (jump bar, search results, thread panels, etc.). |
| src/theme/_activities.scss | Uses panel() for activities panel/container/button radius/border/margins. |
| src/special/_on-hover.scss | Switches hover animations to transform transitions for improved animation performance. |
| src/discord+.scss | Refactors complex :has(...) selector lists into multiple equivalent selectors. |
| src/aki-edition/_dm.scss | Narrows DM transition scope from all to color. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.