Rewrite Hurricane as a multiplatform per-player collision fix - #42
Open
darkcupid412 wants to merge 5 commits into
Open
Rewrite Hurricane as a multiplatform per-player collision fix#42darkcupid412 wants to merge 5 commits into
darkcupid412 wants to merge 5 commits into
Conversation
Replaces the reflection-based global shape mutation with per-player Bedrock collision for bamboo and pointed dripstone across Paper, Folia, Fabric, and NeoForge. Java players and mobs keep vanilla collision. Bedrock detection via local Geyser or backend Floodgate.
onebeastchris
requested changes
Jul 24, 2026
onebeastchris
left a comment
onebeastchris
left a comment
Member
There was a problem hiding this comment.
Hello! Thanks for the PR. Not entirely done reviewing, it is a bit larger in scope; but should be a good start
Comment on lines
+13
to
+19
| dependencies { | ||
| implementation(files(libs.javaClass.superclass.protectionDomain.codeSource.location)) | ||
| implementation(libs.architectury.plugin.library) | ||
| implementation(libs.architectury.loom.plugin) | ||
| implementation(libs.shadow.plugin) | ||
| implementation(libs.minotaur) | ||
| } |
Author
There was a problem hiding this comment.
What's looking off exactly?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR unifies Hurricane and Hurricane-Modded into a single project and replaces the reflection-based collision hack with a per-player fix.
Instead of reflectively zeroing bamboo and pointed dripstone's shared collision shapes (which also affected Java players and mobs), each Bedrock player uses the collision box rendered by their client, calculated from Bedrock's position offset. Java players and mobs retain vanilla collision.
BambooStalkBlockandPointedDripstoneBlock, returning the translated Bedrock collision box when the collision context belongs to a Bedrock player.PlayerFailMoveEventtherefore allows movement rejected only by the vanilla collision box, while aPlayerMoveEventguard prevents movement through the translated Bedrock collision boxes.This rewrite raises the minimum supported Paper version from 1.14 to 1.20.5. Fabric and NeoForge currently target only 26.2.
Tested on Paper 1.20.5, 1.21.10, and 26.2; Folia 26.1.2; Fabric 26.2; and NeoForge 26.2.
Note: AI assistant was used while working on this PR, but the final reviews are done by me. ;p