Dependency Update, Training Improvements, and a PyPI Package#93
Open
JinruG wants to merge 14 commits intoGhadjeres:masterfrom
Open
Dependency Update, Training Improvements, and a PyPI Package#93JinruG wants to merge 14 commits intoGhadjeres:masterfrom
JinruG wants to merge 14 commits intoGhadjeres:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency Compatibility
The original codebase pinned dependencies to versions from 2018–2019 that are now incompatible with modern environments. This PR brings them up to date while preserving full backward compatibility with the existing model architecture and training logic:
Python ≥ 3.9PyTorch ≥ 2.0.0music21 ≥ 8.1.0numpy ≥ 1.23.0Training Improvements
cuda()called beforetrain(): The model previously was moved to GPU only after training, causing the entire training loop to run on CPU.--lr_patienceand--lr_factoroptions above.Dependency Compatibility
deepbach_pytorchPyPI Packagehttps://pypi.org/project/deepbach-pytorch/0.3.6/
A test script (
test.py) is included that exercises the public API entry point:test.py