DRAFT: Show report headings + captions in Word bookmark list#792
Open
ColonelThirtyTwo wants to merge 1 commit intoGhostManager:masterfrom
Open
DRAFT: Show report headings + captions in Word bookmark list#792ColonelThirtyTwo wants to merge 1 commit intoGhostManager:masterfrom
ColonelThirtyTwo wants to merge 1 commit intoGhostManager:masterfrom
Conversation
Remove the `_Ref` prefix from bookmark names in manually named headings
and captions, making them visible in the MS Word bookmark list. Captions
without a bookmark name will still generate a bookmark with the `_Ref`
prefix.
This change won't break existing `{{.ref}}`s (since the prefix is
removed from there too) but will cause previously-hidden caption
bookmarks to appear. Bookmarks can still be hidden by manually prefixing
then name with `_Ref`.
Fixes GhostManager#707
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #792 +/- ##
=======================================
Coverage 91.34% 91.34%
=======================================
Files 367 367
Lines 20728 20728
=======================================
Hits 18935 18935
Misses 1793 1793 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
_Refprefix from bookmark names in manually named headings and captions, making them visible in the MS Word bookmark list. Captions without a bookmark name will still generate a bookmark with the_Refprefix.This change won't break existing
{{.ref}}s (since the prefix is removed from there too) but will cause previously-hidden caption bookmarks to appear. Bookmarks can still be hidden by manually prefixing then name with_Ref.Fixes #707