Skip to content

Fix setuptools#820

Merged
chrismaddalena merged 1 commit intomasterfrom
hotfix/fix-setuptools
Feb 9, 2026
Merged

Fix setuptools#820
chrismaddalena merged 1 commit intomasterfrom
hotfix/fix-setuptools

Conversation

@chrismaddalena
Copy link
Collaborator

@chrismaddalena chrismaddalena commented Feb 9, 2026

This pins setuptools to < v81 to preserve the pkg_resources dependency that v81+ deprecated on February 9th. The pkg_resources is still used by docxcompose, an non-optional dependency for docxtpl. This is not a permanent solution, but it is a necessary change until we can evaluate how to proceed with docxtpl and docxcompose.

Copilot AI review requested due to automatic review settings February 9, 2026 21:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins/controls setuptools to avoid breaking pkg_resources consumers (notably docxcompose via docxtpl) after upstream changes.

Changes:

  • Add a setuptools version constraint in requirements/base.txt.
  • Stop force-upgrading setuptools in the local Django Docker image build.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
requirements/base.txt Introduces a setuptools constraint intended to preserve pkg_resources.
compose/local/django/Dockerfile Avoids overriding the intended setuptools constraint by no longer upgrading it during build.

@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.37%. Comparing base (0c2bbc4) to head (81d8698).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #820   +/-   ##
=======================================
  Coverage   91.37%   91.37%           
=======================================
  Files         368      368           
  Lines       20933    20933           
=======================================
  Hits        19127    19127           
  Misses       1806     1806           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Copilot AI commented Feb 9, 2026

@chrismaddalena I've opened a new pull request, #821, to work on those changes. Once the pull request is ready, I'll request review from you.

@chrismaddalena chrismaddalena merged commit 05eaa66 into master Feb 9, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants