Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Pins/controls setuptools to avoid breaking pkg_resources consumers (notably docxcompose via docxtpl) after upstream changes.
Changes:
- Add a
setuptoolsversion constraint inrequirements/base.txt. - Stop force-upgrading
setuptoolsin the local Django Docker image build.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| requirements/base.txt | Introduces a setuptools constraint intended to preserve pkg_resources. |
| compose/local/django/Dockerfile | Avoids overriding the intended setuptools constraint by no longer upgrading it during build. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #820 +/- ##
=======================================
Coverage 91.37% 91.37%
=======================================
Files 368 368
Lines 20933 20933
=======================================
Hits 19127 19127
Misses 1806 1806 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@chrismaddalena I've opened a new pull request, #821, to work on those changes. Once the pull request is ready, I'll request review from you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pins
setuptoolsto < v81 to preserve thepkg_resourcesdependency that v81+ deprecated on February 9th. Thepkg_resourcesis still used bydocxcompose, an non-optional dependency fordocxtpl. This is not a permanent solution, but it is a necessary change until we can evaluate how to proceed withdocxtplanddocxcompose.