fix: complete bracketed artifact binding guards - #1
Draft
LloydVickeryASI wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relationship to the upstream fix
Incremental follow-up to UsefulSoftwareCo/executor#1884, targeting its
fix/artifact-hyphenated-tool-pathsbranch. This branch starts at3069b15579ff054cfc4fd222a3d44d071392310c; the diff contains only the additions below, not a second copy of the broader hyphenated-path fix.Changes
user/orgsegments in dot or bracket notation on both create and edit, with valid bracket syntax in the error guidance.toolsproperties, dynamic expressions, matching/missing/mismatched connections, atomic edit rejection, and create-to-execute-action resolution.The connection resolver, ownership checks, available-connection inventory and single-call execution contract are unchanged. Dynamic bracket expressions are not newly supported. Client/host wire serialization remains the parent PR's implementation.
Verification
bun run formatandbun run format:check: passed.bun run lint: passed.bun run typecheck: passed across all 45 workspace packages.bun run test: 249 passed across 8 files. The initial sandboxed run could not bind the stdio daemon's loopback listener; the full package passed with local networking available.bun run test src/skills.test.ts: 6 passed.bun run test:selfhost scenarios/artifacts.test.ts -t 'create-artifact hands a non-Apps client': 1 passed, 3 unselected. A fresh local instance verified missing single-quoted bindings, create/edit rejection of bracketed pinned paths, unchanged saved source after rejection, and normal artifact rendering.bun run testand the full cross-target E2E matrix were not run. This is a draft, not a merge/deployment request.Recorded end-to-end evidence
The recording shows the valid artifact still rendering after the negative MCP checks. The rejection/no-persistence assertions are in the scenario source; they are not represented as browser error banners in this recording. All data is synthetic test content.