created buy now button#37
Open
Pallavi024 wants to merge 3 commits intoGirlScriptSummerOfCode:masterfrom
Open
Conversation
Collaborator
|
Hi Pallavi Did you try running your buy now button? React.createClass is deprecated and removed now, you'll have to use ES2015 class syntax. You may refer to other components. |
Author
|
okay
…On Mon, Jul 2, 2018 at 9:20 AM, Divjot Singh ***@***.***> wrote:
Hi Pallavi
Did you try running your buy now button? React.createClass is deprecated
and removed now, you'll have to use ES2015 class syntax. You may refer to
other components.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Ae3EunFNHoFt5RTn1FaFtkoCwMokK3T9ks5uCZhpgaJpZM4U-Mvo>
.
|
bogas04
requested changes
Jul 9, 2018
Collaborator
bogas04
left a comment
bogas04
left a comment
There was a problem hiding this comment.
Hi, could you please make these minor changes? Thank you so much!
components/buybutton.js
Outdated
| * @memberof BuyNow | ||
| */ | ||
|
|
||
| clicked (){ |
Collaborator
There was a problem hiding this comment.
This function isn't required anymore.
| export default class BuyNow extends React.PureComponent { | ||
| /** | ||
| * @typedef {object} BuyNowProps | ||
| * |
| ))} | ||
| </ul> | ||
| </main> | ||
|
|
Collaborator
There was a problem hiding this comment.
Can you remove this change from your commit? You can ask in git_help in case you face an issue :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.