Skip to content

fix(vscode): send schema-valid permission responses#1401

Open
chioarub wants to merge 1 commit into
Gitlawb:mainfrom
chioarub:fix/1034-vscode-permission-response
Open

fix(vscode): send schema-valid permission responses#1401
chioarub wants to merge 1 commit into
Gitlawb:mainfrom
chioarub:fix/1034-vscode-permission-response

Conversation

@chioarub
Copy link
Copy Markdown
Contributor

Summary

  • Fix VS Code chat permission approvals so Allow and Allow for session resolve tool prompts instead of looping.
  • Send schema-valid can_use_tool control responses with behavior, updatedInput, and session updatedPermissions when applicable.
  • Run the extension package test script with Bun's recursive src discovery.

Issue

Fixes #1034

What Changed

  • Added permissionResponse.js helper to build SDK permission results.
  • Store pending control request input and suggestions by request_id in ChatController.
  • Updated sendPermissionResponse to emit correct allow/deny payloads.
  • Updated the VS Code extension test script to run the full extension test set under Bun.

Validation

  • cd vscode-extension/openclaude-vscode && bun test src/chat/permissionResponse.test.js — 3 pass, 0 fail
  • cd vscode-extension/openclaude-vscode && bun run test — 42 pass, 0 fail
  • cd vscode-extension/openclaude-vscode && bun run lint
  • git diff --check

Risk

  • Low — localized VS Code host protocol fix; deny path now uses explicit behavior: 'deny' instead of control error subtype.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The VS Code extension plugin cannot access the disk, and always prompts for permission approval

1 participant