workflows: aggregate a full code generation without the previous review - #34
Merged
Merged
Conversation
A full generation re-reviews the complete current diff from its merge base, which since #31 happens whenever the base branch is merged into the pull request. The aggregation still received the previous code review and was told to preserve still-applicable findings, so blockers about an earlier range survived diffs that no longer contained their subject. Only an incremental generation now carries the previous result, and the full-mode prompt says nothing is carried over. Validation - node .github/scripts/pr-review/test.mjs (the full-generation assertion fails against the previous run.mjs and passes now) - node .github/scripts/issue-review/test.mjs - node .github/scripts/pr-readiness/test.mjs - node .github/scripts/review-request/test.mjs Closes #33 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ OpenAI PR Review: PASS
Conclusion: Ready from the OpenAI review perspective. PR format, linked Issue design, and code/plan conformance passed with no actionable findings.
Review checks
| Check | Result |
|---|---|
| PR format | ✅ PASS |
| Issue design | ✅ PASS |
| Code & plan conformance | ✅ PASS |
Scope: c69a0b2fe2 · 9a785c326b..c69a0b2fe2 · full · 1 diff chunk
Usage: 35s · 147,120 tokens · 72.1% cache hit · 4.031 credits
Summary
Full generation review is complete. Its sole chunk conforms to Issue #33, with no prior review carried into aggregation and no actionable findings.
Review metadata
- Commit:
c69a0b2fe2 - Range:
9a785c326b..c69a0b2fe2 - Mode:
full - Diff chunks:
1 - Model:
gpt-5.6-terra - Reasoning effort:
medium - Session:
repo-1309321116-pr-34-v2 - Generation:
f8e826025fdcee16f367b964a7c5e5e3f795167e8609712e6b7ce5585ca7d6c7 - Evidence:
63a605ecc3d2dbb73029bf0e155a0942bfb04dc7f167c61d6e0d55ee56902707
Totals
- Input:
144,854 - Cached input:
104,396 - Cache write:
40,431 - Output:
2,266 - Reasoning:
929 - Total:
147,120 - Estimated credits:
4.031 - Credit rate per 1M tokens:
62.5input /6.25cached /375output
Token and cache details
| Stage | Mode | Target | Time | Input | Cached | Hit | Output | Total | Credits |
|---|---|---|---|---|---|---|---|---|---|
pr |
deterministic |
format rules |
0s | 0 | 0 | 0.0% | 0 | 0 | 0.000 |
pr |
full |
pr |
8s | 19,548 | 9,274 | 47.4% | 422 | 19,970 | 0.858 |
issue |
full |
Issue #33 |
13s | 39,586 | 33,590 | 84.9% | 826 | 40,412 | 0.894 |
code |
full |
chunk 1/1 |
9s | 39,099 | 17,336 | 44.3% | 779 | 39,878 | 1.761 |
code |
full |
aggregate |
5s | 46,621 | 44,196 | 94.8% | 239 | 46,860 | 0.517 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #31. A
fullcode generation re-reviews the complete current diff from its merge base, which now happens whenever the base branch is merged into the pull request. Its aggregation was still givenprevious_code_reviewand a prompt asking to preserve still-applicable findings and remove only those "demonstrably fixed by the incremental diff". Findings about an earlier range therefore outlived the diff that produced them; on GizClaw/gizclaw#1160 the plan-conformance blocker naming mergedmaincommits persisted across runs until the stored session artifact was deleted.run.mjssuppliesprevious_code_reviewonly when the generation isincremental.previous_code_review; a new scenario merges a moved base branch, pushes further PR work, prepares afullgeneration whose listing holds only PR files, runs the fake Codex with a resumed session, and assertsprevious_code_reviewisnull. That assertion fails against the previousrun.mjs.Validation
node .github/scripts/pr-review/test.mjsrun.mjsnode .github/scripts/issue-review/test.mjsnode .github/scripts/pr-readiness/test.mjsnode .github/scripts/review-request/test.mjsNot run: a live workflow execution.
Closes #33
🤖 Generated with Claude Code