feat: Add util_macros and perf crates to gpui workspace#4
Merged
Conversation
…ngs! from util
Downstream consumers (Glass) depend on `util::path!` and other macros from
`util_macros`. These crates were previously only in the Glass workspace.
Moving them here lets the gpui `util` crate re-export the macros directly,
so `util::path!("/some/path")` works without additional patching.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
util_macrosandperfcrates to the gpui workspace (moved from Glass)utilcrate now re-exportspath!,uri!, andline_endings!macros fromutil_macrosutil::path!("/some/path")without additional patchingContext
Glass depends on
util::path!for cross-platform path handling in tests. Previously these macros only existed in the Glass workspace. By hosting them in gpui, theutilcrate can re-export them directly.Test plan
cargo check -p utilbuilds clean locally🤖 Generated with Claude Code