fix: Add cfg guard to cleanup_native_control for cross-platform compilation#5
Merged
Merged
Conversation
The cleanup_native_control function uses cocoa::base::id and platform::native_controls which are only available on macOS. Without the cfg guard, compilation fails on Linux and Windows. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[cfg(target_os = "macos")]tocleanup_native_controlinnative_element_helpers.rscocoa::base::idandplatform::native_controlswhich are macOS-onlyContext
Without this guard,
cargo checkfails on Linux/Windows with unresolved import errors forcocoaandnative_controls.Test plan
cargo check -p gpuipasses on macOS🤖 Generated with Claude Code