ci(release-verify): document why the audit step pins bash - #109
Merged
Conversation
The caller-supplied command runs through `bash -c "$VAR"` rather than as argv. Today the input comes from a trusted release.yml, so it is not exploitable; the shape still earns a comment, the way rust-ci.yml earns the same one for cross-OS behaviour. The job runs on ubuntu-latest only today, so the PowerShell trap does not apply here. Closes Glyndor/apt#82 [Note: filed against apt because Glyndor/.github has issues disabled; the fix lives in this repo.] Signed-off-by: Jose <75870284+Jaro-c@users.noreply.github.com>
Jaro-c
force-pushed
the
ci/release-verify-pin-bash-comment
branch
from
August 9, 2026 21:34
0b6e493 to
f8dc1cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a comment in front of the
bash -c "$AUDIT_COMMAND"run step, explaining the choice ofbash -c "$VAR"over an argv array.Why
The input comes from a trusted
workflow_callcaller — a repo-ownedrelease.yml— so it is not exploitable today. But the shape earns the same commentrust-ci.ymlcarries for the cross-OS PowerShell trap:bash -cevaluates a string rather than receiving argv, and a future caller can construct a value that interacts badly with shell expansion.This job runs on
ubuntu-latestonly, so the PowerShell half of that pattern does not apply here; the comment states that explicitly so the next reader does not have to re-derive it.The ideal follow-up is to take
audit-commandas an argv array, removing the parsing entirely. That is a separate change.Closes Glyndor/apt#82 (filed against apt because
Glyndor/.githubhas issues disabled; the fix lives in this repo).