ci(release-verify): per-asset signature verification, plus SHA256SUMS gate - #110
Merged
Conversation
Jaro-c
force-pushed
the
ci/per-asset-sig-verify
branch
2 times, most recently
from
August 10, 2026 04:00
f3faa80 to
1ad6c80
Compare
… gate Two real security improvements, in the reusables that gate every release. 1. installer-contract.yml: assert the release workflow publishes a SHA256SUMS manifest. The install scripts verify downloaded binaries against this file; a release that stops producing it is a silent breaking change (install.sh fetches the URL and gets a 404 mid-installer, the failure mode that motivated the gate). The check matches the presence of the path on the manifest side, not the upload step name on the workflow side, so it stays valid across workflow renames. 2. release-verify.yml: per-asset signature verification. The signature covers each binary independently, so a manifest re-signed to legitimize a swapped binary still fails the check (a manifest-only check would pass that case). Iterates every per-asset .sig (per-binary, per-deb, per-SBOM, per-installer), not just SHA256SUMS.sig, using the org Ed25519 release key as input. Skipped for manifest-kind: go because Go modules use the tag itself, not per-binary signatures. Closes the per-binary substitution gap that #1359 closed in podup's own release workflow. The org reusable should not require every consumer to reimplement it. Signed-off-by: Jose <75870284+Jaro-c@users.noreply.github.com>
Jaro-c
force-pushed
the
ci/per-asset-sig-verify
branch
from
August 10, 2026 04:01
1ad6c80 to
ade9547
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two real security improvements, in the reusables that gate every release.
installer-contract.yml— assert the release workflow publishes aSHA256SUMSmanifest. The install scripts verify downloaded binaries against this file; a release that stops producing it is a silent breaking change (install.sh fetches the URL and gets a 404 mid-installer). The check matches the presence of the path on the manifest side, not the upload step name on the workflow side, so it stays valid across workflow renames.release-verify.yml— per-asset signature verification. Iterates every per-asset.sig(per-binary, per-deb, per-SBOM, per-installer), not justSHA256SUMS.sig. The signature covers each binary independently, so a manifest re-signed to legitimize a swapped binary still fails the check (a manifest-only check would pass that case). Uses the org Ed25519 release key as a new input (release-pubkey-b64) with the current key as default. Skipped formanifest-kind: gobecause Go modules are versioned by the tag itself.Why this matters
This is the same gap that Glyndor/podup#1359 closed in podup's own release workflow: a per-binary substitution where the manifest could be re-signed to match a swapped binary. The org reusable should not require every consumer to reimplement it.
The manifest-only SHA256SUMS check in
installer-contract.ymlcloses a separate failure mode: install.sh keeps fetching the manifest URL even when the release stops producing it, and gets a 404 mid-installer. Catching the missingSHA256SUMSasset at PR time is the cheap fix.Test plan
actor a real workflow dispatch with a known-good release and confirm both checks pass.sigand confirm release-verify fails with a clear messageSHA256SUMSand confirm installer-contract failsSigned-off-by: Jose 75870284+Jaro-c@users.noreply.github.com