ci: verify release signature against the pinned install key, sign from env - #82
Merged
Conversation
…sign from env Two release-integrity fixes prompted by the broken v1.4.0: - Gate publishing on the signature verifying against the exact public key setup-agent.sh, update-agent.sh and the self-update code pin, and assert those three pins agree. A release the installer would reject can no longer ship — this is the check that was missing when v1.4.0 went out signed by a key its installer no longer trusted. - Read the signing key from GLYNDOR_RELEASE_ED25519_KEY in sign.py instead of passing it as an argv, so it never lands in the runner's process table. Signed-off-by: Jaro-c <75870284+Jaro-c@users.noreply.github.com>
Jaro-c
added
type:ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prompted by the broken v1.4.0 (signed by the org key while the installer still pinned the retired one — no gate caught it before publish).
Note: release.yml only runs on a tag, so PR CI does not exercise it — the verify logic and pin extraction were validated locally against the published v1.4.1 assets.