fix(release): accept the org signing seed, not only seed+pub - #38
Merged
Conversation
The signer required a 64-byte seed+pub and rejected anything else. The org secret GLYNDOR_RELEASE_ED25519_KEY is a raw 32-byte seed -- that is what podup's signer reads, and what signed podup 1.9.1 -- so pointing this workflow at the shared key (#32) is not enough on its own: the sign step dies with "key size 32, want 64" and the release never publishes. Verified by running it, not by reading it: with a 32-byte seed the signer previously exited 1; it now signs, and the signature verifies against the public key derived from that seed -- which is exactly the check updater.go performs in the field. Accept both forms. ed25519.NewKeyFromSeed expands a 32-byte seed into the 64-byte private key, and the 64-byte form still works untouched, so no existing caller breaks. A wrong length is still refused. This mismatch is likely why unitpm drifted onto a release key of its own while the docs described one shared key: the shared key could not be used here at all. Signed-off-by: Jaro-c <75870284+Jaro-c@users.noreply.github.com>
Jaro-c
force-pushed
the
fix/sign-accepts-org-seed
branch
from
July 15, 2026 13:39
3db86ab to
c6b3191
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#32 alone won't let unitpm release. It points the workflow at
GLYNDOR_RELEASE_ED25519_KEYand embedsHFv7…— both correct — but the signer refuses that secret:sign.gorequired a 64-byte seed+pub. The org secret is a raw 32-byte seed — that's what podup'ssign.pyreads (must decode to 32 bytes) and what signed podup 1.9.1 an hour ago. So the sign step dies and the release never publishes.This is very likely why unitpm drifted onto a key of its own (
3eSCGskG…) while the docs described one shared key: the shared key was unusable here. Not carelessness — incompatibility.Accepts both forms:
ed25519.NewKeyFromSeedexpands a 32-byte seed to the 64-byte private key, and the 64-byte form still works untouched, so nothing existing breaks. A wrong length is still refused.Verified by running it, not reading it (Go 1.26.4, locally):
gofmt,go vet,go buildall clean.Wants to land together with #32 — one without the other still leaves unitpm unable to cut a release.