Skip to content

fix(release): accept the org signing seed, not only seed+pub - #38

Merged
Jaro-c merged 1 commit into
mainfrom
fix/sign-accepts-org-seed
Jul 15, 2026
Merged

fix(release): accept the org signing seed, not only seed+pub#38
Jaro-c merged 1 commit into
mainfrom
fix/sign-accepts-org-seed

Conversation

@Jaro-c

@Jaro-c Jaro-c commented Jul 15, 2026

Copy link
Copy Markdown
Member

#32 alone won't let unitpm release. It points the workflow at GLYNDOR_RELEASE_ED25519_KEY and embeds HFv7… — both correct — but the signer refuses that secret:

$ RELEASE_SIGNING_KEY=<32-byte seed> go run scripts/sign.go file
key size 32, want 64
exit status 1

sign.go required a 64-byte seed+pub. The org secret is a raw 32-byte seed — that's what podup's sign.py reads (must decode to 32 bytes) and what signed podup 1.9.1 an hour ago. So the sign step dies and the release never publishes.

This is very likely why unitpm drifted onto a key of its own (3eSCGskG…) while the docs described one shared key: the shared key was unusable here. Not carelessness — incompatibility.

Accepts both forms: ed25519.NewKeyFromSeed expands a 32-byte seed to the 64-byte private key, and the 64-byte form still works untouched, so nothing existing breaks. A wrong length is still refused.

Verified by running it, not reading it (Go 1.26.4, locally):

input before after
32-byte seed (the real secret) , exit 1 signs — and the signature verifies against the public key derived from that seed, which is the check performs in the field
64-byte seed+pub signs signs
48 bytes rejected , exit 1

gofmt, go vet, go build all clean.

Wants to land together with #32 — one without the other still leaves unitpm unable to cut a release.

The signer required a 64-byte seed+pub and rejected anything else. The
org secret GLYNDOR_RELEASE_ED25519_KEY is a raw 32-byte seed -- that is
what podup's signer reads, and what signed podup 1.9.1 -- so pointing
this workflow at the shared key (#32) is not enough on its own: the sign
step dies with "key size 32, want 64" and the release never publishes.

Verified by running it, not by reading it: with a 32-byte seed the signer
previously exited 1; it now signs, and the signature verifies against the
public key derived from that seed -- which is exactly the check
updater.go performs in the field.

Accept both forms. ed25519.NewKeyFromSeed expands a 32-byte seed into the
64-byte private key, and the 64-byte form still works untouched, so no
existing caller breaks. A wrong length is still refused.

This mismatch is likely why unitpm drifted onto a release key of its own
while the docs described one shared key: the shared key could not be used
here at all.

Signed-off-by: Jaro-c <75870284+Jaro-c@users.noreply.github.com>
@Jaro-c
Jaro-c force-pushed the fix/sign-accepts-org-seed branch from 3db86ab to c6b3191 Compare July 15, 2026 13:39
@Jaro-c
Jaro-c merged commit 9834ec4 into main Jul 15, 2026
11 checks passed
@Jaro-c
Jaro-c deleted the fix/sign-accepts-org-seed branch July 15, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant