Remove dead duplicate webhook path, add ESLint, unhide 3 test files from tsc

[godamongstmen897]

Investigating the "unwired" dispatchMilestoneWebhook turned up something different from what I reported last time: it isn't missing wiring, it's a second webhook system competing with one that already works.

The live path

src/indexer/webhook-delivery.ts → deliverWebhooks() is imported by src/indexer/poller.ts and runs after every poll. It filters by contract_id, filters by event_types with the same * / JSON-array / literal logic, retries with backoff, and logs. The public POST /api/webhooks/subscribe endpoint feeds it via addSubscription.

The dead path

src/webhooks/{dispatcher,deliver,milestone-events}.ts reimplements the same filtering with a milestone-shaped payload. Nothing outside that directory imports any of it. Wiring it up would have double-delivered every event in two different shapes — a regression, not a fix. Removed.

That takes the prototype-chain fix from #403 with it. That fix was correct, but the module it fixed shouldn't exist; the live path never had the bug because it doesn't map event names to statuses.

Three exported functions that always threw

db.ts declared CREATE TABLE IF NOT EXISTS webhook_subscriptions twice with different schemas. The per-contract one is declared first, so it wins and the second never runs. It also declared interface WebhookSubscription twice — TypeScript merges duplicate interfaces, so the type described neither table.

addWebhookSubscription, removeWebhookSubscription and getWebhookSubscriptions all query a url column that therefore doesn't exist. Verified against a real database:

columns: id, contract_id, webhook_url, event_types, created_at
addSubscription           -> OK
addWebhookSubscription    -> THROWS: table has no column named url
getWebhookSubscriptions   -> THROWS: no such column: url
removeWebhookSubscription -> THROWS: no such column: url

Nothing calls them. Removed, with the dead table declaration and duplicate interface.

ESLint

The backend had no linter and no lint step. Added eslint 9 + typescript-eslint with the type-aware parser, npm run lint, and a CI step before the type check.

Calibrated to be green today and useful tomorrow. Errors — rules that catch what tsc cannot: no-prototype-builtins (exactly the in bug above, which type-checked fine), guard-for-in, no-floating-promises, await-thenable, no-useless-catch, prefer-const, eqeqeq. Warnings — pre-existing debt: no-unused-vars, no-unsafe-call, no-explicit-any, 128 of them, mostly Stellar SDK call sites in routes/jobs.ts that need a proper typing pass. 0 errors, so the gate is real.

Fixed the 4 it found: three no-op catch (e) { throw e } wrappers and a prefer-const.

Worth being precise about scope: this would not have stopped #401. That branch failed tsc — the corruption was already caught, and it was merged anyway. A linter helps with what type-checking misses, not with merging past a red build.

Also unhidden

tsconfig excluded three test suites from type checking — ledger-range-tracker-improvements, indexer-metrics-collector-concurrency, failover-recovery-backoff-retry. They run under jest but tsc never saw them. Removed the exclusions: they type-check with zero errors, so the exclusion was hiding nothing — but could have hidden anything. Same class as the jest testPathIgnorePatterns removed in #402. Added jest.setup.ts for the same reason.

---

lint 0 errors, tsc 0 errors, 1612 tests pass, build clean.

🤖 Generated with Claude Code

[Copilot]

🟡 Changes recommended

The new ESLint config relies on import.meta.dirname (not broadly supported across Node versions) and the lockfile marks the chosen ESLint version as deprecated, both of which can destabilize the new CI lint gate.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR removes an unused/duplicate webhook delivery implementation (and its associated tests and broken DB helpers), adds ESLint (with a CI lint gate), and broadens TypeScript compilation coverage to include previously excluded test files (plus jest.setup.ts).

Changes:

• Deleted the unused src/webhooks/* milestone webhook pipeline to avoid competing webhook delivery paths.
• Removed a dead/incorrect webhook_subscriptions table definition and unused DB helpers that targeted a non-existent url column.
• Added ESLint + npm run lint and a CI lint step; updated tsconfig.json include/exclude so test files and jest.setup.ts are type-checked.

File summaries

File	Description
tsconfig.json	Includes jest.setup.ts and removes exclusions so more tests are type-checked.
eslint.config.mjs	Adds ESLint flat config + TypeScript-ESLint ruleset and test overrides.
.github/workflows/ci.yml	Adds npm run lint step before tsc in CI.
package.json	Adds lint script and ESLint + TypeScript-ESLint dev dependencies.
package-lock.json	Locks new ESLint / TypeScript-ESLint dependency graph.
src/indexer/db.ts	Removes duplicate webhook_subscriptions table and unused global-subscription helpers.
src/webhooks/milestone-events.ts	Deleted (unused milestone webhook event/type logic).
src/webhooks/dispatcher.ts	Deleted (unused dispatcher entrypoint).
src/webhooks/deliver.ts	Deleted (unused delivery implementation).
tests/rpc-poller-client.test.ts	Removes no-op catch { throw } wrappers.
tests/milestone-webhook-events.test.ts	Deleted (tests for removed milestone webhook module).
tests/database-writer-pool.test.ts	Minor prefer-const cleanup.

Review details

• Files reviewed: 10/12 changed files
• Comments generated: 2
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.