Skip to content

refactor(storage): consolidate admin_set_yield_rate ledger footprint - #419

Merged
godamongstmen897 merged 1 commit into
Goldii-locks:mainfrom
Awosdot:feature/issue-407-reduce-yield-rate-footprint
Sep 1, 2026
Merged

refactor(storage): consolidate admin_set_yield_rate ledger footprint#419
godamongstmen897 merged 1 commit into
Goldii-locks:mainfrom
Awosdot:feature/issue-407-reduce-yield-rate-footprint

Conversation

@Awosdot

@Awosdot Awosdot commented Aug 28, 2026

Copy link
Copy Markdown

Summary

  • Introduces a single YieldConfig { pub yield_rate: u32 } struct stored under DataKey::YieldConfig, replacing the standalone DataKey::YieldRateBps key in both contracts/milestone-escrow/src/lib.rs and contracts/reports/src/lib.rs.
  • Updates admin_set_yield_rate and the get_yield_info getter in both files to read/write through the consolidated struct, reducing the ledger footprint of yield-rate related writes.

Test plan

  • cargo test passes (449 tests) for the milestone-escrow workspace crate.
  • Verified contracts/reports/src/lib.rs compiles and its test suite runs cleanly against the change (one pre-existing, unrelated failure — test_multisig_transfer_admin_high_precision_split_preserves_every_unit — reproduces identically on main before this change, so it is not a regression).

Closes #407

@drips-wave

drips-wave Bot commented Aug 28, 2026

Copy link
Copy Markdown

@Awosdot Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Awosdot

Awosdot commented Aug 30, 2026

Copy link
Copy Markdown
Author

Please check and merge

@godamongstmen897
godamongstmen897 merged commit 7686d26 into Goldii-locks:main Sep 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce the ledger storage footprint of admin_set_yield_rate

2 participants