refactor(storage): consolidate admin_set_yield_rate ledger footprint - #419
Merged
godamongstmen897 merged 1 commit intoSep 1, 2026
Conversation
|
@Awosdot Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
Please check and merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
YieldConfig { pub yield_rate: u32 }struct stored underDataKey::YieldConfig, replacing the standaloneDataKey::YieldRateBpskey in bothcontracts/milestone-escrow/src/lib.rsandcontracts/reports/src/lib.rs.admin_set_yield_rateand theget_yield_infogetter in both files to read/write through the consolidated struct, reducing the ledger footprint of yield-rate related writes.Test plan
cargo testpasses (449 tests) for themilestone-escrowworkspace crate.contracts/reports/src/lib.rscompiles and its test suite runs cleanly against the change (one pre-existing, unrelated failure —test_multisig_transfer_admin_high_precision_split_preserves_every_unit— reproduces identically onmainbefore this change, so it is not a regression).Closes #407