Skip to content

feat: enhance MicroBridge functionality and improve transaction history styling#262

Open
EmekaManuel wants to merge 3 commits intoGoodDollar:masterfrom
EmekaManuel:fix/good-design-tx
Open

feat: enhance MicroBridge functionality and improve transaction history styling#262
EmekaManuel wants to merge 3 commits intoGoodDollar:masterfrom
EmekaManuel:fix/good-design-tx

Conversation

@EmekaManuel
Copy link

@EmekaManuel EmekaManuel commented Mar 4, 2026

Bug: Fix Microbridge UI/UX Issues

#251

Description

This PR fixes two UI/UX bugs in the microbridge flow that were preventing users from creating multiple bridge transactions and causing visual inconsistency in the transaction history.

Issues Fixed

  1. isBridging State Not Resetting: After creating a bridge request, users were unable to create another transaction because the isBridging state was never reset, blocking the UI even after the transaction completed successfully or failed.

  2. fixed the font issue too with transaction amount

Impact: Users can now immediately create another bridge request after a transaction completes, without being blocked by the UI state.

Summary by Sourcery

Improve the MicroBridge flow to allow consecutive bridge transactions and enhance the readability of the transaction history UI.

Bug Fixes:

  • Ensure the bridging state is reset once relay processing finishes so users can start a new bridge transaction after completion or failure.

Enhancements:

  • Improve transaction history layout with truncation, overflow handling, and consistent typography for hashes, addresses, amounts, and fees to prevent wrapping and visual glitches.

…ry display

- Added relayCompleted state to track relay status in MicroBridge component.
- Updated bridging logic to ensure users can initiate new transactions after relay completion.
- Improved layout and overflow handling in BridgeHistoryWithRelay for better transaction display.
- Ensured transaction details are truncated for better readability.
@EmekaManuel EmekaManuel changed the title feat: enhance MicroBridge functionality and improve transaction histo… feat: enhance MicroBridge functionality and improve transaction history styling Mar 4, 2026
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The relayCompleted flag in MicroBridge is derived entirely from bridgeStatus/relayStatus, so consider computing it directly inside the effect instead of storing it in state to simplify the dependency array and avoid subtle state-sync bugs.
  • The repeated targetChainId.toNumber() === 122 ? ... : ... checks for chain names and explorer chainId lookups in MicroBridgeController could be refactored into a small helper or mapping to reduce duplication and the risk of inconsistent updates.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The `relayCompleted` flag in `MicroBridge` is derived entirely from `bridgeStatus`/`relayStatus`, so consider computing it directly inside the effect instead of storing it in state to simplify the dependency array and avoid subtle state-sync bugs.
- The repeated `targetChainId.toNumber() === 122 ? ... : ...` checks for chain names and explorer `chainId` lookups in `MicroBridgeController` could be refactored into a small helper or mapping to reduce duplication and the risk of inconsistent updates.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

- Removed unnecessary relayCompleted state from MicroBridge component.
- Simplified bridging logic to improve user experience during transactions.
- Introduced getBridgeChainInfo function to centralize chain ID mapping and improve readability.
- Updated transaction history display to dynamically show source and target chain names.
@L03TJ3 L03TJ3 linked an issue Mar 6, 2026 that may be closed by this pull request
@L03TJ3
Copy link
Collaborator

L03TJ3 commented Mar 6, 2026

@EmekaManuel make sure in other PR's that related screens or demo-videos are included in the PR
not only on telegram.

Sharing here for visibility:
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what all these changes are?
the only thing to fix was to have the font-sizing aligned.

It seems even (looking at the screenshot) that these proposed changes break previously working sections.
(it was a table based layout. your current UI does not align column-headers with the column)

(below is from our dev environment, not from your PR)
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Micro bridge: UI/UX bugs

2 participants