feat: enhance MicroBridge functionality and improve transaction history styling#262
Open
EmekaManuel wants to merge 3 commits intoGoodDollar:masterfrom
Open
feat: enhance MicroBridge functionality and improve transaction history styling#262EmekaManuel wants to merge 3 commits intoGoodDollar:masterfrom
EmekaManuel wants to merge 3 commits intoGoodDollar:masterfrom
Conversation
…ry display - Added relayCompleted state to track relay status in MicroBridge component. - Updated bridging logic to ensure users can initiate new transactions after relay completion. - Improved layout and overflow handling in BridgeHistoryWithRelay for better transaction display. - Ensured transaction details are truncated for better readability.
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
relayCompletedflag inMicroBridgeis derived entirely frombridgeStatus/relayStatus, so consider computing it directly inside the effect instead of storing it in state to simplify the dependency array and avoid subtle state-sync bugs. - The repeated
targetChainId.toNumber() === 122 ? ... : ...checks for chain names and explorerchainIdlookups inMicroBridgeControllercould be refactored into a small helper or mapping to reduce duplication and the risk of inconsistent updates.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `relayCompleted` flag in `MicroBridge` is derived entirely from `bridgeStatus`/`relayStatus`, so consider computing it directly inside the effect instead of storing it in state to simplify the dependency array and avoid subtle state-sync bugs.
- The repeated `targetChainId.toNumber() === 122 ? ... : ...` checks for chain names and explorer `chainId` lookups in `MicroBridgeController` could be refactored into a small helper or mapping to reduce duplication and the risk of inconsistent updates.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
- Removed unnecessary relayCompleted state from MicroBridge component. - Simplified bridging logic to improve user experience during transactions. - Introduced getBridgeChainInfo function to centralize chain ID mapping and improve readability. - Updated transaction history display to dynamically show source and target chain names.
Collaborator
|
@EmekaManuel make sure in other PR's that related screens or demo-videos are included in the PR |
L03TJ3
requested changes
Mar 6, 2026
Collaborator
There was a problem hiding this comment.
I have no idea what all these changes are?
the only thing to fix was to have the font-sizing aligned.
It seems even (looking at the screenshot) that these proposed changes break previously working sections.
(it was a table based layout. your current UI does not align column-headers with the column)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Bug: Fix Microbridge UI/UX Issues
#251
Description
This PR fixes two UI/UX bugs in the microbridge flow that were preventing users from creating multiple bridge transactions and causing visual inconsistency in the transaction history.
Issues Fixed
isBridging State Not Resetting: After creating a bridge request, users were unable to create another transaction because the
isBridgingstate was never reset, blocking the UI even after the transaction completed successfully or failed.fixed the font issue too with transaction amount
Impact: Users can now immediately create another bridge request after a transaction completes, without being blocked by the UI state.
Summary by Sourcery
Improve the MicroBridge flow to allow consecutive bridge transactions and enhance the readability of the transaction history UI.
Bug Fixes:
Enhancements: