fix: escape inner double quotes in helm --set to preserve annotation key quoting#151
Merged
vigneshrajsb merged 3 commits intomainfrom Mar 31, 2026
Merged
fix: escape inner double quotes in helm --set to preserve annotation key quoting#151vigneshrajsb merged 3 commits intomainfrom
vigneshrajsb merged 3 commits intomainfrom
Conversation
Helm --set keys containing annotation paths like ingress.extraAnnotations."app\.kubernetes\.io/name" use inner double quotes to prevent / from being interpreted as a path separator. Wrapping with outer double quotes caused the shell to break on the inner quotes, stripping them before Helm could see them.
Escape inner " as \" within the outer double-quoted --set argument instead of switching to single quotes. This preserves the double-quote wrapping for all values while still passing inner quotes through to Helm.
vigneshrajsb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--setkeys for Kubernetes annotations use inner double quotes to prevent/from being interpreted as a nested path separator (e.g.,ingress.extraAnnotations."app\.kubernetes\.io/name")--setargument caused the shell to break on these inner quotes, stripping them before Helm could process themcannot unmarshal object into Go struct field .metadata.annotations of type string"as\"within the outer double-quoted--setargument so they pass through to Helm untouchedTest plan