[codex] Support native Helm post renderers and custom images#155
Draft
vigneshrajsb wants to merge 18 commits intomainfrom
Draft
[codex] Support native Helm post renderers and custom images#155vigneshrajsb wants to merge 18 commits intomainfrom
vigneshrajsb wants to merge 18 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This adds native Helm support for a configurable job image and an optional post-renderer path.
The native Helm job can now:
--post-renderer <path>when native Helm config provides oneWhy
Some Helm deployments rely on renderer behavior that was previously only available through a custom CI step image. Native Helm jobs need a way to use the same renderer behavior without depending on a CI-specific step type.
Impact
This keeps the native Helm flow in control of command construction while adding a narrow extension point for renderer-backed deployments. Deployments that do not need a renderer are unchanged.
Validation
pnpm exec jest src/server/lib/nativeHelm/__tests__/helm.test.ts --runInBandNotes
The tests use generic image values and generic renderer examples only.