[DO NOT MERGE] Validate beam 2.76.0 RC2 - #4135
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request prepares the repository for the validation of Apache Beam 2.76.0 RC2. It involves bumping the core Beam version, updating the associated Maven repository, and cleaning up Python dependency lists to ensure compatibility and consistency with the new release candidate. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates Apache Beam and its linked dependencies to version 2.76.0 (specifically 2.76.0rc2 for Python) across Maven and Python requirements files. It also modifies the validateCandidate Maven profile activation. Feedback points out that the JDK activation range [1.) introduced in pom.xml is syntactically invalid in Maven and should be corrected to a valid range such as [1.8,).
| <id>validateCandidate</id> | ||
| <activation> | ||
| <activeByDefault>false</activeByDefault> | ||
| <jdk>[1.)</jdk> |
There was a problem hiding this comment.
The JDK activation range [1.) is syntactically invalid in Maven. A valid version range requires a comma to separate the lower and upper bounds (e.g., [1.8,) or [1,)). Please correct this to a valid range such as [1.8,) or [11,) depending on the minimum supported JDK version.
| <jdk>[1.)</jdk> | |
| <jdk>[1.8,)</jdk> |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4135 +/- ##
============================================
- Coverage 56.21% 56.21% -0.01%
Complexity 7340 7340
============================================
Files 1126 1126
Lines 68748 68748
Branches 7784 7784
============================================
- Hits 38650 38649 -1
- Misses 27599 27602 +3
+ Partials 2499 2497 -2
🚀 New features to boost your workflow:
|
|
|
|
testBigQueryToBigQuery: Caused by apache/beam@eb9e7a3 Due to that ManagedIO is still on Beam 2.75.0 and doesn't support deserialize GcsOption |
|
DataStreamToBigQuery tests pipeline and checkers was successful, but stuck at clean up: It appears the test is also highly flaky on main branch: https://github.com/GoogleCloudPlatform/DataflowTemplates/actions/workflows/datastream-pr.yml Likely unrelated to the Beam version bump. Need to fix the test on main branch. |
No description provided.