Exclude jline from transitive dependencies of hadoop

[kennknowles]

jline was being pulled in transitively via hadoop-yarn-client, which is used by several hadoop dependencies (hadoop-common, hadoop-client, hadoop-mapreduce-client-core).

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request cleans up the project's dependency graph by removing an unnecessary transitive dependency. By explicitly excluding jline from hadoop-yarn-client, the build environment is streamlined, reducing the risk of dependency conflicts and keeping the project's classpath lean.

Highlights

• Dependency Management: Added an explicit exclusion for the org.jline:jline artifact within the hadoop-yarn-client dependency definition to prevent it from being pulled in transitively.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds the hadoop-yarn-client dependency to the pom.xml file, excluding the jline artifact. There are no review comments, and I have no feedback to provide.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.87%. Comparing base (9084300) to head (2095354).

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #4148      +/-   ##
============================================
- Coverage     55.89%   55.87%   -0.03%     
+ Complexity     7426     7425       -1     
============================================
  Files          1132     1132              
  Lines         69667    69667              
  Branches       7918     7918              
============================================
- Hits          38941    38926      -15     
- Misses        28231    28244      +13     
- Partials       2495     2497       +2     

Components	Coverage Δ
spanner-templates	84.69% <ø> (-0.01%)	⬇️
spanner-import-export	68.90% <ø> (-0.13%)	⬇️
spanner-live-forward-migration	88.81% <ø> (-0.02%)	⬇️
spanner-live-reverse-replication	81.38% <ø> (-0.02%)	⬇️
spanner-bulk-migration	89.14% <ø> (-0.01%)	⬇️
gcs-spanner-dv	88.03% <ø> (-0.02%)	⬇️
see 7 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[kennknowles]

This won't pass until rebased on #4143 , which is failing to get green (unknown cause currently).

[kennknowles]

The failing test is not healthy:

However, I want to kick it until it goes green if I can.

[Abacn]

Yeah DataStream test is not relevant to this change, trying to fix in #4159

[kennknowles]

OK - if you think it is safe to merge, then I will do so after approval. My understanding is that jline is only used in a hadoop CLI that someone made, so it is not needed for use of the library. I think the transitive dep on hadoop is from kafka and those tests are green.