Skip to content

Bump timeout for DataStreamToBigQueryIT and Ignore newly added test - #4180

Merged
Abacn merged 1 commit into
GoogleCloudPlatform:mainfrom
Abacn:bump-timeout
Aug 26, 2026
Merged

Bump timeout for DataStreamToBigQueryIT and Ignore newly added test#4180
Abacn merged 1 commit into
GoogleCloudPlatform:mainfrom
Abacn:bump-timeout

Conversation

@Abacn

@Abacn Abacn commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Mitigate #2459

See #4039 (comment) currently tests are very flaky

@Abacn
Abacn requested a review from a team as a code owner August 25, 2026 15:04
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses ongoing flakiness in the DataStreamToBigQuery integration tests. By extending the global timeout and temporarily disabling a problematic test case, the changes aim to stabilize the CI pipeline while the underlying issues are investigated.

Highlights

  • Timeout Adjustment: Increased the test timeout from 40 to 60 minutes in DataStreamToBigQueryIT to accommodate slow test execution.
  • Test Suppression: Added @ignore to the testDataStreamPostgresToBigQuery test case to mitigate flakiness issues tracked in issue [Bug]: Improve the Datastream IT time #2459.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increases the integration test timeout from 40 to 60 minutes, links a GitHub issue to the TODO comment, and ignores the Postgres-to-BigQuery integration test. The reviewer suggested reducing the timeout from 60 minutes to 35 minutes, noting that a 60-minute timeout is excessively high and could block the CI pipeline for too long if a test hangs, especially since the maximum pipeline wait time is 25 minutes.

@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.90%. Comparing base (9f81d23) to head (1c721cf).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4180   +/-   ##
=========================================
  Coverage     55.90%   55.90%           
- Complexity     7475     7477    +2     
=========================================
  Files          1134     1134           
  Lines         70135    70135           
  Branches       8014     8014           
=========================================
+ Hits          39207    39211    +4     
+ Misses        28381    28377    -4     
  Partials       2547     2547           
Components Coverage Δ
spanner-templates 84.64% <ø> (-0.01%) ⬇️
spanner-import-export 69.02% <ø> (+0.02%) ⬆️
spanner-live-forward-migration 88.65% <ø> (-0.02%) ⬇️
spanner-live-reverse-replication 81.25% <ø> (-0.02%) ⬇️
spanner-bulk-migration 89.06% <ø> (-0.01%) ⬇️
gcs-spanner-dv 87.85% <ø> (-0.02%) ⬇️
see 3 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Abacn

Abacn commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

A test failing in com.google.cloud.teleport.v2.mongodb.templates.MongoDbToBigQueryIT not related to this change

@Abacn

Abacn commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

R: @yonatandt @noyKonforty

@Abacn

Abacn commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

R: @derrickaw

@Abacn
Abacn merged commit d9fa0f1 into GoogleCloudPlatform:main Aug 26, 2026
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants