Bump timeout for DataStreamToBigQueryIT and Ignore newly added test - #4180
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses ongoing flakiness in the DataStreamToBigQuery integration tests. By extending the global timeout and temporarily disabling a problematic test case, the changes aim to stabilize the CI pipeline while the underlying issues are investigated. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request increases the integration test timeout from 40 to 60 minutes, links a GitHub issue to the TODO comment, and ignores the Postgres-to-BigQuery integration test. The reviewer suggested reducing the timeout from 60 minutes to 35 minutes, noting that a 60-minute timeout is excessively high and could block the CI pipeline for too long if a test hangs, especially since the maximum pipeline wait time is 25 minutes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4180 +/- ##
=========================================
Coverage 55.90% 55.90%
- Complexity 7475 7477 +2
=========================================
Files 1134 1134
Lines 70135 70135
Branches 8014 8014
=========================================
+ Hits 39207 39211 +4
+ Misses 28381 28377 -4
Partials 2547 2547
🚀 New features to boost your workflow:
|
|
A test failing in com.google.cloud.teleport.v2.mongodb.templates.MongoDbToBigQueryIT not related to this change |
|
R: @derrickaw |
Mitigate #2459
See #4039 (comment) currently tests are very flaky