Replace python-jose with google alternative#566
Replace python-jose with google alternative#566Jipje wants to merge 5 commits intoGoogleCloudPlatform:mainfrom
Conversation
Removing the insecure python-jose package
|
Here is the summary of changes. You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
|
@Jipje thanks for raising this and investigating a solution /gcbrun |
|
Cheers @iennae, happy to help out. I am unable to view the details of the kokoro build so am unsure as to why it fails. Is it anything to do with the adjusted |
|
Bumping this @iennae |
| AUDIENCE = None | ||
|
|
||
|
|
||
| # [START getting_started_auth_certs] |
There was a problem hiding this comment.
@Jipje can you let me know about why you're removing this block here? Thanks.
There was a problem hiding this comment.
(I answered my own question. I need to fix some stuff in documentation because removing this block will break a page. )
don't create a conflict with pre-existing region tags; ensure that existing region tag doesn't break here
Closes #565
For more context to why python-jose should be replaced, please reference #565
This solution is a modified version of another repository of GoogleCloudPlatform: https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/iap/validate_jwt.py. Although the code was modified as to minimize the amount of changes necessary in this repository.
The
certs()method andCERTSglobal have been replaced by acerts_urlparameter in theverify_tokenmethod. This did not change behaviour in the tests.