Skip to content

Fix: resolve relative concept links in the graph viewer detail panel #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryanb93 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: resolve relative concept links in the graph viewer detail panel #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 33 additions & 13 deletions okf/src/reference_agent/viewer/static/viz.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@
const html = marked.parse(body, { breaks: false, gfm: true });
const bodyEl = document.getElementById("detail-body");
bodyEl.innerHTML = html;
rewriteInternalLinks(bodyEl);
rewriteInternalLinks(bodyEl, conceptId);

const bl = backlinks[conceptId] || [];
const blSection = document.getElementById("detail-backlinks");
Expand Down Expand Up @@ -213,21 +213,41 @@
cy.animate({ center: { eles: node }, zoom: Math.max(cy.zoom(), 1.0) }, { duration: 200 });
}

function rewriteInternalLinks(root) {
// Resolve a markdown-link href to a concept id, honoring both absolute
// ("/clinical/careplan.md") and relative ("../clinical/careplan.md",
// "founding-member-v1.md") links, the latter relative to currentId's dir.
function hrefToConceptId(href, currentId) {
let h = href.split("#")[0];
if (!h.endsWith(".md")) return null;
h = h.slice(0, -3);
let parts;
if (h.startsWith("/")) {
parts = h.slice(1).split("/");
} else {
parts = currentId.split("/").slice(0, -1).concat(h.split("/"));
}
const out = [];
for (const p of parts) {
if (p === "" || p === ".") continue;
if (p === "..") out.pop();
else out.push(p);
}
return out.join("/");
}

function rewriteInternalLinks(root, currentId) {
root.querySelectorAll("a[href]").forEach((a) => {
const href = a.getAttribute("href");
if (!href) return;
if (href.startsWith("/") && href.endsWith(".md")) {
const target = href.slice(1, -3);
if (nodeIndex[target]) {
a.className = "internal";
a.setAttribute("href", "javascript:void(0)");
a.addEventListener("click", (e) => {
e.preventDefault();
showDetail(target);
});
return;
}
const target = hrefToConceptId(href, currentId || "");
if (target && nodeIndex[target]) {
a.className = "internal";
a.setAttribute("href", "javascript:void(0)");
a.addEventListener("click", (e) => {
e.preventDefault();
showDetail(target);
});
return;
}
a.className = "external";
a.setAttribute("target", "_blank");
Expand Down