Skip to content

bug fix#389

Merged
KudratAroraa merged 3 commits into
masterfrom
admin_navigation_dailyReportFix
May 28, 2026
Merged

bug fix#389
KudratAroraa merged 3 commits into
masterfrom
admin_navigation_dailyReportFix

Conversation

@sakthiarajapandian27
Copy link
Copy Markdown
Collaborator

Description

Bug Fix for navigation

Todos

  • Tested and working locally
  • Code follows the style guidelines of this project
  • I have performed a self-review of my code
  • Code changes documented
  • Requested review from >= 2 devs on the team (one frontend and one backend recommended)

How to test

Login as admin -> Click on Daily Report -> Click Side -> Test home and Sign out functionality

Screenshots and/or Gifs

[Insert screenshots and/or gifs showing the graphic representation of the change]

Associated MS Planner Tasks

Known Issues

None

@KudratAroraa
Copy link
Copy Markdown
Collaborator

Applied spotless formatting for CI

@KudratAroraa KudratAroraa self-assigned this May 28, 2026
Copy link
Copy Markdown
Collaborator

@KudratAroraa KudratAroraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

I reviewed the changes and this PR looks good for its intended scope. The Daily Report screen navigation issue has been addressed by adding proper drawer item handling for Home and Sign out, and the Home navigation now correctly routes based on the current logged-in role. This makes the side navigation behaviour more consistent and fixes the missing admin/caretaker navigation flow from this screen.

The change is focused, relevant to the reported bug, and aligns well with the stated testing flow. Overall, this looks good to merge.

Future improvement note: later, the sign-out flow can also be aligned with the broader app authentication flow by clearing the back stack consistently when navigating back to login, but that is not a blocker for this PR.

@KudratAroraa KudratAroraa merged commit cff630a into master May 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants