Fix profile phone hydration after encrypted profile updates#267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update fixes the profile phone/address hydration issue after saving user profile changes.
Fixed profile update response flow so the API now re-fetches the canonical profile after update, ensuring contactNumber and address are returned from decrypted profile_encrypted data.
Prevented encrypted raw values from leaking to clients by sanitizing unresolved encrypted payloads (legacy/ciphertext-like strings) to null.
Applied the same sanitization/decryption guard in both profile read and update model paths for consistent behavior.
Files updated
/model/getUserProfile.js
/model/updateUserProfile.js
/services/userProfileService.js
Result
Saving profile now correctly returns hydrated profile fields.
UI no longer receives ciphertext-like phone/address values.
Phone number field remains empty only when data cannot be decrypted with the current backend encryption key.