ci: require both checks on main pull requests#2
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR ensures that both required branch-protection checks (test-python-agent and evaluate) always run on PRs targeting main, by removing path-based filters that could cause them to be skipped. It also adds workflow-level concurrency groups to cancel superseded runs.
Changes:
- Remove path filters from
python-agent-tests.ymland addbranches: [main]filters for bothpushandpull_requesttriggers, ensuring tests always run. - Scope
eval-gate.yml'spull_requesttrigger to themainbranch only. - Add
concurrencyblocks withcancel-in-progress: trueto both workflows.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/python-agent-tests.yml |
Replaced path filters with branch filters (main); added concurrency group to cancel superseded runs. |
.github/workflows/eval-gate.yml |
Scoped pull_request to main branch; added concurrency group to cancel superseded runs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
python-agent-testsalways runs for PRs tomain(remove path-filter skips).eval-gateto PRs targetingmain.Why
Branch protection requires
test-python-agentandevaluatechecks. Path-filter skips could leave required checks missing on some PRs.Validation
npm run agent:test:py(25 tests passed)