Respect existing Authorization header in web_fetch (case-insensitive)#9
Open
GopiB9119 wants to merge 1 commit into
Open
Respect existing Authorization header in web_fetch (case-insensitive)#9GopiB9119 wants to merge 1 commit into
GopiB9119 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Updates web_fetch to avoid injecting/overriding an Authorization header when the caller already provided one, regardless of header name casing.
Changes:
- Detect an existing
Authorizationheader case-insensitively before adding the bearer token. - Add a regression test ensuring a caller-supplied lowercase
authorizationheader is preserved.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
agent/agent/web_tools.py |
Adds a case-insensitive check for an existing Authorization header prior to bearer injection. |
agent/agent/tests/test_web_tools.py |
Adds a regression test for preserving a caller-provided authorization header. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
web_fetchfrom auto-injecting or overriding anAuthorizationheader when the caller already provided one in any casing.Description
Authorizationheader before injecting the bearer token and add a regression test that ensures a lowercaseauthorizationheader supplied by the caller is preserved.Testing
pytest -q agent/agent/tests/test_web_tools.pyand full test suitepytest -q, and both completed successfully (tests passed).Codex Task