feat: Distinguish empty-state messages in PullRequestsTab#212
Merged
Conversation
Contributor
|
distinguishing the empty-state messages in the pull requests tab is a nice ux detail, much clearer than a single generic message. rebased on latest main, merged. thanks! |
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implemented the empty-state split in the Pull Requests tab and added comprehensive test coverage for each state.
Changes
src/features/maintainers/components/pull-requests/PullRequestsTab.tsxrole="status".src/features/maintainers/components/pull-requests/PullRequestsTab.test.tsxvite.config.tsvitest.config.tsVerification
Passed
npx eslint src/features/maintainers/components/pull-requests/PullRequestsTab.tsx src/features/maintainers/components/pull-requests/PullRequestsTab.test.tsxgit diff --checkKnown Issues
npm run typecheckType checking is currently failing due to unrelated pre-existing issues in:
src/shared/components/SearchModal.tsxsrc/shared/utils/focusTrap.tsTest Execution
Unable to complete an end-to-end Vitest run in the current environment because the config loader fails while resolving
vitest.config.tswith:Security Impact
closes #81