Skip to content

fix(a11y): add aria-label to LanguageIcon fallback dot and memoize component — #184 #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jagadeeshftw merged 2 commits into from
Jun 23, 2026
Merged

fix(a11y): add aria-label to LanguageIcon fallback dot and memoize component — #184 #213

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
293ec23
fix(a11y): add aria-label to LanguageIcon fallback and memoize component
leocagli Jun 23, 2026
f946d4a
Merge remote-tracking branch 'origin/main' into pr-213
Baskarayelu Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/shared/components/LanguageIcon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { memo, useMemo } from 'react';
import {
siTypescript,
siJavascript,
Expand Down Expand Up @@ -89,8 +90,8 @@ const cssIconPath = "M1.5 0h21l-1.91 21.563L11.977 24l-8.564-2.438L1.5 0zm17.09
// Batchfile (Windows CMD) - terminal-style icon
const batchfileIconPath = "M2 4h20v16H2V4zm2 2v2h16V6H4zm0 4h16v2H4v-2zm0 4h10v2H4v-2z";

export function LanguageIcon({ language, className = 'w-4 h-4' }: LanguageIconProps) {
const config = languageMapping[language];
export const LanguageIcon = memo(function LanguageIcon({ language, className = 'w-4 h-4' }: LanguageIconProps) {
const config = useMemo(() => languageMapping[language], [language]);

// Special handling for CSS (no icon in simple-icons)
if (language === 'CSS') {
Expand Down Expand Up @@ -125,8 +126,13 @@ export function LanguageIcon({ language, className = 'w-4 h-4' }: LanguageIconPr
}

if (!config) {
// Fallback to colored dot if language not found
return <div className={`rounded-full bg-[#9b8b7a] ${className}`} />;
return (
<div
role="img"
aria-label={language}
className={`rounded-full bg-[#9b8b7a] ${className}`}
/>
);
}

return (
Expand All @@ -141,4 +147,4 @@ export function LanguageIcon({ language, className = 'w-4 h-4' }: LanguageIconPr
<path d={config.icon.path} />
</svg>
);
}
});