test(e2e): run Playwright across chromium, firefox, and webkit#219
Merged
Jagadeeshftw merged 2 commits intoJun 23, 2026
Conversation
d1e4002 to
3f0f830
Compare
Contributor
|
running the playwright e2e suite across chromium, firefox and webkit gives real cross-browser confidence. rebased on latest main and merged. thanks! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run Playwright e2e across Firefox and WebKit in addition to Chromium
📌 Description
This PR addresses issue #98 by adding Firefox and WebKit rendering engines to our Playwright E2E test configuration. In addition, it fixes pre-existing TypeScript compilation and Vitest configuration issues to ensure tests run cleanly and reliably.
🔍 Problem
playwright.config.tswas only configured to run E2E tests onchromium, leaving potential cross-browser rendering or behavior regressions in Firefox and WebKit/Safari uncaught.FiltersSection.tsx,useOptimisticData.ts,logger.test.ts).e2e/*.spec.ts), which led to syntax and runtime errors due to environment differences.✅ Solution
1. Cross-Browser E2E Testing Config (
playwright.config.ts)firefoxandwebkitproject configurations using standard Playwright devices (Desktop FirefoxandDesktop Safari).2. Stabilization and Build Cleanups
src/shared/hooks/useOptimisticData.ts.cacheKeyinsrc/shared/hooks/useOptimisticData.test.tsto solve implicit any type warnings.useEffecthook structure insrc/features/leaderboard/components/FiltersSection.tsx.src/shared/utils/logger.test.tsto use Vitestvi.stubEnv/vi.unstubAllEnvsinstead of mutating read-only env descriptors withObject.defineProperty(which fails on Node 22/Vite 6/Vitest 4).testconfigurations tovite.config.tsto usejsdomby default and excludee2efiles from unit testing.jsdomand@testing-library/reactdev dependencies to support all unit tests.3. Documentation (
README.md)E2E Testingsection inREADME.mdexplaining how to run the E2E tests and how to run on a single browser locally (e.g.,pnpm run test:e2e --project=firefox).🧪 Testing and Test Output
All unit and e2e configurations compile and typecheck clean:
pnpm run typecheckpasses successfully.pnpm run test(Vitest unit tests) passes successfully with all 18 tests green.🔒 Security Notes
Closes #98