Centralize chapter queue creation - #499
Draft
ceroxlol wants to merge 3 commits into
Draft
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
This seems pretty benign, because as far as I can see we just move the code around slightly. At the same we have a test that runs green before and after. So what is the actual purpose of the change? |
Owner
|
seems like just a refactor. Welcomed, but we have to wait unless it's ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR centralizes the existing chapter queue construction without changing playback behavior. PlaybackService, MediaSession item resolution, and playback resumption now use the same code path.
This refactoring is intentionally separate from track playback. Keeping the first PR behavior-neutral makes it easier to verify that queue construction has not regressed and gives the later feature work one well-tested integration point.
This PR is part of a series of PRs targeting the implementation of having two modes of playback, chapters and tracks.
All the following 6 PRs contribute to this goal, but for the sake of clarity and easier readability, are divided in to multiple parts.