Skip to content

LAYOUT-1: /signup fits the window (branding beside form on large screens)#104

Merged
mvalancy merged 1 commit into
devfrom
fix/signin-fit-no-scroll
Jun 18, 2026
Merged

LAYOUT-1: /signup fits the window (branding beside form on large screens)#104
mvalancy merged 1 commit into
devfrom
fix/signin-fit-no-scroll

Conversation

@mvalancy

Copy link
Copy Markdown
Member

What

The /signup (magic-link) page stacked branding above a single max-w-md column, so it needed vertical scrolling on a big window (live audit: scrollH 1196 > 1000 @1600×1000). Per the "fit the window" design religion, on lg+ screens the branding now sits beside the form in a wider 2-column grid (max-w-4xl); on small screens it stacks as before. Footer/dev-info stay below the grid, full-width.

Verification

  • tests/e2e/signup-fit.spec.ts @signup-fit — large screen: branding is left of the form sharing the row + the form fits the viewport height; phone: no horizontal overflow. 2/2.
  • Absolute "no vertical scroll" is gated by the live cloud audit (production has none of the dev-only chrome — the HTTP "insecure connection" banner and "Default Accounts" box — that inflates a dev-server height measurement). Will confirm on the post-deploy audit.

🤖 Generated with Claude Code

… screens

The auth page stacked branding above a single max-w-md column, so it needed
vertical scrolling on a big window (live audit: scrollH 1196 > 1000 @1600x1000).
Per the "fit the window" design religion, on lg+ screens the branding now sits
BESIDE the form in a wider 2-column grid (max-w-4xl), so the flow fits without
scrolling; on small screens it stacks as before. Footer/dev-info stay below the
grid full-width.

Test: tests/e2e/signup-fit.spec.ts @signup-fit — large screen shows branding to
the left of the form sharing the row + form fits the viewport height; phone has
no horizontal overflow. (Absolute no-vertical-scroll is gated in the live cloud
audit, since prod has none of the dev-only chrome — HTTP banner, Default
Accounts box — that inflates a dev-server measurement.)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

🧪 Comprehensive Test Suite

  • Unit suites (Node 18.x & 20.x) — core, web, server, mcp-server: ✅ passed
  • Installer & deploy config: ✅ passed

Full-stack smoke gate runs in the CI workflow.

@mvalancy mvalancy merged commit 675ffcc into dev Jun 18, 2026
16 checks passed
@mvalancy mvalancy deleted the fix/signin-fit-no-scroll branch June 18, 2026 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant