fix(dashboard): drop -1 fps sentinels from large-graph trends#140
Merged
Conversation
…rends Commit 36924ad guarded scaleSweepMetrics against the -1 "not-measured" sentinel but left largeGraphMetrics unguarded. The large-graph profiler writes dragFps = -1 (and likewise for fps it cannot sample when the node element is absent), so those sentinels charted as real 0-ish data points, polluting the fps trend lines. Apply the same negative-as-not-measured guard. Adds a unit test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🧪 Comprehensive Test Suite
Full-stack smoke gate runs in the CI workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends #138's sentinel guard to largeGraphMetrics (dragFps=-1 was charting as real data). +1 unit test, all 34 dashboard tests green.