fix(dashboard): drop stale -1 sentinel metrics from served trends#141
Merged
Conversation
…ic trends Ingestion (metrics.mjs) already filters -1 sentinels, but the append-only metrics.jsonl retains points written before that fix landed, so the served state still carried -1 for graph.driftPx/avgTickMs. A -1 on a lower-is-better metric reads as a perfect score and distorts the trend chart. Add a liveMetrics() guard at the serve layer dropping non-finite/negative values (every GraphDone metric is non-negative). Dedup-on-append still reads raw. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🧪 Comprehensive Test Suite
Full-stack smoke gate runs in the CI workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The live test dashboard still serves
-1forgraph.driftPxandgraph.avgTickMsin metric trends. Ingestion already filters these (commit 24eb497 for FPS; metrics.mjsmeasured()for sweep/large-graph), but the append-onlymetrics.jsonlretains points written before those fixes. A-1on a lower-is-better metric reads as a perfect score and distorts the trend chart.Fix
Add
liveMetrics()inhistory.mjs— a defensive guard at the serve layer (server.mjs:104) dropping non-finite/negative metric values. Every GraphDone metric (fps, ms, px, counts, scores) is non-negative, so a negative is always a not-measured sentinel. Dedup-on-append (server.mjs:84) keeps reading raw.Test
liveMetricsunit test added; full dashboard suite green (35/35 vianode --test). Pure read-layer change — no app data/graph/deletion paths touched, so smoke gate is not the relevant gate.