Tyler and Tong pull request review#5
Open
JayWoo2000 wants to merge 35 commits into
Open
Conversation
…cess_utils Add multiprocessing utils
…needed_files Add a testing struct
xxEoD2242
requested changes
Nov 18, 2021
xxEoD2242
left a comment
xxEoD2242
left a comment
Collaborator
There was a problem hiding this comment.
Need a good layout of what this algorithm, how it works and what we need to implement, including class and method comment, I/O comments, etc.
| if(grid[i]): | ||
| pass | ||
| else: | ||
| xC = i//(n * o) |
Collaborator
There was a problem hiding this comment.
Add comments to explain what xC, yC, zC are and the same for state
| if(ystat and zstat and not grid[i - o - 1]): self.graph.add_edge((xC, yC, zC), (xC, yC - 1, zC - 1), math.sqrt(2)) | ||
| if(xstat and ystat and zstat and not grid[i - (m * o) - o - 1]): self.graph.add_edge((xC, yC, zC), (xC - 1, yC - 1, zC - 1), math.sqrt(3)) | ||
| return dijkstar.find_path(self.graph, tuple(start), tuple(end)).nodes | ||
| else: |
Collaborator
There was a problem hiding this comment.
What is this else statement for?
Collaborator
|
@JayWoo2000 @MarvinMui You need to add a |
…0 changed to in [, 0]
fixed one minor vulnerabilites: "== None" changed to "is None"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working module for airsim