Skip to content

handling new workflow for user auth - #23

Merged
AkibDa merged 1 commit into
GreenPlateByCodeNewbies:mainfrom
AkibDa:main
Jan 9, 2026
Merged

AkibDa merged 1 commit into
GreenPlateByCodeNewbies:mainfrom
AkibDa:main

Conversation

@AkibDa

@AkibDa AkibDa commented Jan 9, 2026

Copy link
Copy Markdown
Member

No description provided.

@AkibDa
AkibDa merged commit b00ee41 into GreenPlateByCodeNewbies:main Jan 9, 2026
2 of 3 checks passed
Comment thread app/auth.py
if not college_id:
try:
auth.delete_user(uid)
except:

Check notice

Code scanning / Bandit (reported by Codacy)

Try, Except, Pass detected. Note

Try, Except, Pass detected.

@github-advanced-security github-advanced-security AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pylintpython3 (reported by Codacy) found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@github-advanced-security github-advanced-security AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pylint (reported by Codacy) found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Comment thread app/auth.py

import os, requests
from .schema import LoginSchema, SignUpSchema
import os

Check warning

Code scanning / Prospector (reported by Codacy)

Unused import os (unused-import) Warning

Unused import os (unused-import)
Comment thread app/auth.py

def _get_college_by_domain(email: str):
try:
if not email: return None, None

Check warning

Code scanning / Prospector (reported by Codacy)

Bad indentation. Found 2 spaces, expected 4 (bad-indentation) Warning

Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
Comment thread app/auth.py

def _get_college_by_domain(email: str):
try:
if not email: return None, None

Check warning

Code scanning / Prospector (reported by Codacy)

Bad indentation. Found 4 spaces, expected 8 (bad-indentation) Warning

Bad indentation. Found 4 spaces, expected 8 (bad-indentation)
Comment thread app/auth.py
except Exception as e:
return _create_response(status.HTTP_500_INTERNAL_SERVER_ERROR, str(e))

try:

Check warning

Code scanning / Prospector (reported by Codacy)

Bad indentation. Found 4 spaces, expected 8 (bad-indentation) Warning

Bad indentation. Found 4 spaces, expected 8 (bad-indentation)
Comment thread app/auth.py

try:
decoded = auth.verify_id_token(token)
except Exception:

Check warning

Code scanning / Prospector (reported by Codacy)

Bad indentation. Found 4 spaces, expected 8 (bad-indentation) Warning

Bad indentation. Found 4 spaces, expected 8 (bad-indentation)
Comment thread app/auth.py

if not college_id:
try:
auth.delete_user(uid)

Check warning

Code scanning / Prospector (reported by Codacy)

Bad indentation. Found 8 spaces, expected 16 (bad-indentation) Warning

Bad indentation. Found 8 spaces, expected 16 (bad-indentation)
Comment thread app/auth.py
if not college_id:
try:
auth.delete_user(uid)
except:

Check warning

Code scanning / Prospector (reported by Codacy)

No exception type(s) specified (bare-except) Warning

No exception type(s) specified (bare-except)
Comment thread app/auth.py
if not college_id:
try:
auth.delete_user(uid)
except:

Check warning

Code scanning / Prospector (reported by Codacy)

Bad indentation. Found 6 spaces, expected 12 (bad-indentation) Warning

Bad indentation. Found 6 spaces, expected 12 (bad-indentation)
Comment thread app/auth.py
try:
auth.delete_user(uid)
except:
pass

Check warning

Code scanning / Prospector (reported by Codacy)

Bad indentation. Found 8 spaces, expected 16 (bad-indentation) Warning

Bad indentation. Found 8 spaces, expected 16 (bad-indentation)
Comment thread app/auth.py
error_msg = response_data.get("error", {}).get("message", "Login failed")
return _create_response(status.HTTP_401_UNAUTHORIZED, error_msg)

user_doc_ref.set({

Check warning

Code scanning / Prospector (reported by Codacy)

Bad indentation. Found 4 spaces, expected 8 (bad-indentation) Warning

Bad indentation. Found 4 spaces, expected 8 (bad-indentation)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants