GG-651: Use options inside CreateConnectionPool() - #23
Merged
Conversation
Use all flags (except for password ones) inside CreateConnectionPool() for connecting to dbms. Change type and default values of some flags. Also, add scrapeDbNames flag for future checks if source db name is not specified. - names will need to be grabbed.
Add unit tests with mocking. Probably more need to come.
As SRS was further specified, we no longer need SOURCE_NO_PASSWORD and TARGET_NO_PASSWORD options. They are either requested through pgpass file.
VoidZeroNull0
marked this pull request as ready for review
July 30, 2026 08:33
riogor
requested changes
Aug 3, 2026
riogor
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
After merging implementation of utilitty functions and option parsing,
connection creation (CreateConnectionPool()) with parsed flags is still needed.
This PR implements exactly this. Also uses default values if no flag provided
according to SRS.
Ticket: GG-651