Skip to content

Stronghold of Player Safety#884

Open
M1krofin wants to merge 17 commits intoGregHib:mainfrom
M1krofin:Player_safety_dungeon
Open

Stronghold of Player Safety#884
M1krofin wants to merge 17 commits intoGregHib:mainfrom
M1krofin:Player_safety_dungeon

Conversation

@M1krofin
Copy link
Contributor

@M1krofin M1krofin commented Feb 7, 2026

Almost fully working working stronghold with cockroach combat, sounds and drop tables.

Npc dialogues has been added.

Working crevice shortcut and treasure chest containing goodies.

Todo in future is adding Gublinch jail cell interfaces. After this it's pretty much fully added

Copy link
Owner

@GregHib GregHib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delayed review, a few small bits but overall looking good!

delay(2)
areaSound("unlock", target.tile)
delay(3)
target.replace("stronghold_of_player_safety_an_old_lever_opened")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
target.replace("stronghold_of_player_safety_an_old_lever_opened")

The varbit handles the object change (this would change it for all players)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm when i have done this change the lever bugs out :D Can this be fixed somehow or is it because of the varbit? I tried to use clearAnim() but it does not change anything.

lever_bugs_out.mp4

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm changing the varbit manually seemed to work fine, not sure why it's doing that

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a closer look, I think the animations are wrong if you comment out target.anim it looks fine and the varbit isn't supposed to move the lever all the way to the back

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested without the varbit and the animation looked correct for the lever. Delayed too but the lever did not move all the way back. I guess the varbit and anim somehow colission together even with delays and clearAnim making it look like it goes all the way down. Oh well not a big deal but interesting thing to see. Here is the video

without_varbit.mp4

I will push the chnage without animation and try later in future this more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants