Skip to content

Fixes for Newer Clang Versions #1827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fthaler wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes for Newer Clang Versions #1827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b33fff
Fixes for newer Clang versions
fthaler Feb 23, 2026
b97df28
Merge remote-tracking branch 'upstream/master' into clang-fixes
fthaler Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions include/gridtools/common/hymap.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ namespace gridtools {
template <class...>
struct values;

#if !defined(__NVCC__) && defined(__clang__) && __clang_major__ <= 17
#if !defined(__NVCC__) && defined(__clang__)
template <class... Vs>
values(Vs const &...) -> values<Vs...>;
#endif
Expand All @@ -213,16 +213,18 @@ namespace gridtools {
template <class... Keys>
template <class... Vals>
struct keys<Keys...>::values {
#if !defined(__clang__) || __clang_major__ < 18
static_assert(sizeof...(Vals) == sizeof...(Keys), "invalid hymap");
#endif

tuple<Vals...> m_vals;

template <class... Args,
std::enable_if_t<std::conjunction_v<std::is_constructible<Vals, Args>...>, int> = 0>
std::enable_if_t<sizeof...(Args) == sizeof...(Vals) &&
std::conjunction_v<std::is_constructible<Vals, Args>...>,
int> = 0>
constexpr GT_FUNCTION values(Args &&...args) noexcept : m_vals{std::forward<Args>(args)...} {}

constexpr GT_FUNCTION values(Vals const &...args) noexcept : m_vals(args...) {}

constexpr GT_FUNCTION values(tuple<Vals...> &&args) noexcept : m_vals(std::move(args)) {}
constexpr GT_FUNCTION values(tuple<Vals...> const &args) noexcept : m_vals(args) {}

Expand All @@ -234,10 +236,7 @@ namespace gridtools {

template <class Src>
constexpr GT_FUNCTION
std::enable_if_t<((!std::is_same_v<values, std::decay_t<Src>> && is_hymap<std::decay_t<Src>>::value) &&
... &&
std::is_assignable_v<Vals &,
std::add_lvalue_reference_t<element_at<Keys, std::remove_reference_t<Src>>>>),
std::enable_if_t<!std::is_same_v<values, std::decay_t<Src>> && is_hymap<std::decay_t<Src>>::value,
values &>
operator=(Src &&src) {
(...,
Expand Down
2 changes: 1 addition & 1 deletion include/gridtools/stencil/frontend/cartesian/expressions/expr_pow.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ namespace gridtools {
struct pow_f {
template <class Arg>
GT_FUNCTION constexpr auto operator()(Arg const &arg) const {
return gt_pow<I>::template apply(arg);
return gt_pow<I>::apply(arg);
}
};

Expand Down
Loading