fix[cartesian]: minified SDFG wihout duplication#2486
Open
romanc wants to merge 2 commits intoGridTools:mainfrom
Open
fix[cartesian]: minified SDFG wihout duplication#2486romanc wants to merge 2 commits intoGridTools:mainfrom
romanc wants to merge 2 commits intoGridTools:mainfrom
Conversation
This PR works towards reducing the size of SDFGs saved to disk. Included in this PR are 1. stripping the history, though that didn't make a difference in tests 2. updating DaCe to save SDFGs compressed by default and without whitespace.
romanc
changed the title
This PR updates DaCe for gt4py.cartesian to address the issue with dupicated nodes in SDFGs. This includes a fix DaCe-side to avoid duplicating nodes/edges of conditionals in the SDFG written to disk. Nodes and edges are already contained in the `branches` section.
Contributor
Author
|
Update: with the last DaCe fix added today, this PR will now properly fix the size increase observed when moving form DaCe v1 to v2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Building on top #2485, this PR works towards reducing the size of SDFGs saved to disk. Included in this PR are
@FlorianDeconinck feel free to merge over night. DaCe changes an be viewed here.
Requirements
Assumed to be covered by existing tests.
N/A